Skip to content

Commit

Permalink
Change intention and change verbose string text
Browse files Browse the repository at this point in the history
  • Loading branch information
urosstan-db committed Feb 19, 2024
1 parent 128e9c9 commit bac32da
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ case class RowDataSourceScanExec(
override def verboseStringWithOperatorId(): String = {
super.verboseStringWithOperatorId() + (rdd match {
case externalEngineDatasourceRdd: ExternalEngineDatasourceRDD =>
"Executed query: " +
"External engine query: " +
externalEngineDatasourceRdd.getExternalEngineQuery +
System.lineSeparator()
case _ => ""
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -81,8 +81,9 @@ class JdbcSQLQueryBuilder(dialect: JdbcDialect, options: JDBCOptions) {
/**
* Constructs the WHERE clause that following dialect's SQL syntax.
*/
def withPredicates(predicates: Array[Predicate],
part: Option[JDBCPartition]): JdbcSQLQueryBuilder = {
def withPredicates(
predicates: Array[Predicate],
part: Option[JDBCPartition]): JdbcSQLQueryBuilder = {
// `filters`, but as a WHERE clause suitable for injection into a SQL query.
val filterWhereClause: String = {
predicates.flatMap(dialect.compileExpression(_)).map(p => s"($p)").mkString(" AND ")
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3026,6 +3026,6 @@ class JDBCV2Suite extends QueryTest with SharedSparkSession with ExplainSuiteHel
test("Explain shows executed SQL query") {
val df = sql("SELECT max(id) FROM h2.test.people WHERE id > 1")
val explained = getNormalizedExplain(df, FormattedMode)
assert(explained.contains("Executed query:"))
assert(explained.contains("External engine query:"))
}
}

0 comments on commit bac32da

Please sign in to comment.