Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request disappears from UI list when percent sign (%) in password field #1076

Closed
PrimeF opened this issue Nov 28, 2023 · 6 comments
Closed
Labels
bug Something isn't working

Comments

@PrimeF
Copy link

PrimeF commented Nov 28, 2023

When the password field of the basic auth configuration contains a percent sign %, the request is not recognised and shown in the app.

Example request:

meta {
  name: ABC
  type: http
  seq: 1
}

get {
  url: https://abc.com/
  body: none
  auth: basic
}

auth:basic {
  username: USER
  password: A%
}

By removing the percent sign and restarting the app or moving the request's JSON file to another location and back the request pops up.

Bruno version used: v1.2.0

@bpoulaindev
Copy link
Contributor

bpoulaindev commented Dec 7, 2023

The issue seem to come from bruToJson and bruToJsonV2 :
image
One request disappeared after the conversion

@likwidoxigen
Copy link

Also unable to save when a Multipart Form param contains newlines. Example is Oracle WebCenterRest where the sample is un-minified json.

@sanjai0py sanjai0py added the bug Something isn't working label Jul 3, 2024
@sanjai0py
Copy link
Member

Closing this as it cannot be reproduced in the latest version of Bruno v1.20.1

Screen.Recording.2024-07-05.at.12.21.12.PM.mov

@likwidoxigen
Copy link

Closing this as it cannot be reproduced in the latest version of Bruno v1.20.1

Should I open a new issue for the newlines in parameters preventing saves?

@sanjai0py
Copy link
Member

Hey @likwidoxigen, could you please check again? In the latest version of Bruno, multipart form data supports multiline values.

Screen.Recording.2024-07-09.at.11.55.05.AM.mov

@likwidoxigen
Copy link

@sanjai0py It's my fault for being imprecise.
It does work to include newlines in body params for a multi-part request.
It does not work in the regular params for the request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants