Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

编辑状态下，如果刷新页面，编辑框上的 “Editing...” 和 Cancel按钮就会消失 #329

Closed
Zeng1998 opened this issue Oct 21, 2022 · 2 comments · Fixed by #388
Closed

编辑状态下，如果刷新页面，编辑框上的 “Editing...” 和 Cancel按钮就会消失 #329

Zeng1998 opened this issue Oct 21, 2022 · 2 comments · Fixed by #388
Labels
enhancement New feature or request

Comments

@Zeng1998
Copy link
Contributor

Describe the bug

好像是刷新后 editorState.editMemoId 这个就变成undefined了。

（但我不知道怎么修比较好

Steps to reproduce

  1. 双击进入编辑状态
  2. 刷新页面

Expected behavior

刷新前后页面状态一致

Screenshots or additional context

No response
@Zeng1998 Zeng1998 added the bug Something isn't working label Oct 21, 2022
@boojack
Copy link
Member

boojack commented Oct 21, 2022

符合预期。

@boojack boojack added enhancement New feature or request and removed bug Something isn't working labels Oct 21, 2022
@Zeng1998
Copy link
Contributor Author

符合预期。

Hi, do you think we should use redux-persist package to keep the editor state when refresh the page?

@boojack boojack linked a pull request Oct 31, 2022 that will close this issue
feat: cache editing memo id #388
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: cache editing memo id usememos/memos
2 participants
@boojack @Zeng1998