Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check the logic of getting a btc_address' pending xUDT output cells #159

Closed
Flouse opened this issue Jun 4, 2024 · 0 comments · Fixed by #162
Closed

Check the logic of getting a btc_address' pending xUDT output cells #159

Flouse opened this issue Jun 4, 2024 · 0 comments · Fixed by #162
Assignees
@ahonn
Labels
bug Something isn't working P-Medium

Comments

@Flouse
Copy link
Contributor

Flouse commented Jun 4, 2024 •
edited
Loading

Context

https://github.com/ckb-cell/btc-assets-api/blob/3fb45d978ad4bfa2f1911ef0190a761769239ad7/src/services/transaction.ts#L583-L617

The result returned by getPendingOuputCellsByTxids may contain some cells that belong to other btc_addresses.

Proposal function

fn getPendingOuputCellsByUTXO(utxo: UTXO) {
  const job = await this.getTransactionRequest(utxo.txid); 
  ...
  
  // TODO: check the cell.rgbpp-lock.args.out_index === utxo.vout
  
  ...
  
  return cells;
}

References
@Flouse Flouse added the bug Something isn't working label Jun 4, 2024
@Flouse Flouse changed the title Check the logic of getting pending xUDT output cells Check the logic of getting a btc_address' pending xUDT output cells Jun 4, 2024
@Flouse Flouse added the P-Medium label Jun 4, 2024
@ahonn ahonn linked a pull request Jun 5, 2024 that will close this issue
fix: check pending xudt amount cells lock #162
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ahonn ahonn

Labels
bug Something isn't working P-Medium
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: check pending xudt amount cells lock utxostack/btc-assets-api
2 participants
@Flouse @ahonn