Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two times invocation of the com.vaadin.flow.router.HasUrlParameter#setParameter method in Vaadin Flow 24.4.0.rc1 #19540

Open
Tracked by #5012
alexanoid opened this issue Jun 7, 2024 · 12 comments

Comments

@alexanoid
Copy link

alexanoid commented Jun 7, 2024

Description of the bug

This issue occurred once before, then you fixed it, and now it has returned in Vaadin Flow 24.4.0.rc1. When accessing the page, the method сom.vaadin.flow.router.HasUrlParameter#setParameter is called twice.

I also use vaadin.eagerServerLoad=true

In version 24.4.0.beta5 everything works fine, so apparently something has changed in Vaadin Flow 24.4.0.rc1.

Expected behavior

method com.vaadin.flow.router.HasUrlParameter#setParameter is called only one time

Minimal reproducible example

n/a

Versions

  • Vaadin / Flow version: 24.4.0.rc1
  • Java version: 17
  • OS version: Windows 10
@mshabarov
Copy link
Contributor

Has the same root cause (extra history navigation event) as in #19525 and #19494

@mcollovati
Copy link
Collaborator

I was unable to reproduce with a simple view implementing HasUrlParameter in 24.4.0.rc1. I tried it with and without vaadin.eagerServerLoad setting, but the setParameter is invoked once.

@Artur-
Copy link
Member

Artur- commented Jun 7, 2024

It does not happen on initial load but only on navigation, and #19539 fixes it

@github-project-automation github-project-automation bot moved this from 🔖 High Priority (P1) to ✅ Closed in Vaadin Flow bugs & maintenance (Vaadin 10+) Jun 10, 2024
@github-project-automation github-project-automation bot moved this from 🟢Ready to Go to Done in Vaadin Flow ongoing work (Vaadin 10+) Jun 10, 2024
@alexanoid
Copy link
Author

alexanoid commented Jun 11, 2024

In which version will this fix be released? I tried 24.4.0.rc2 but it still doesn't work.

@alexanoid
Copy link
Author

alexanoid commented Jun 12, 2024

@Artur- I tried with 24.4.1, the same problem

@Artur-
Copy link
Member

Artur- commented Jun 12, 2024

Then it sounds like a different problem that needs a test case

@Artur- Artur- reopened this Jun 12, 2024
@alexanoid
Copy link
Author

@artur Would it be sufficient to show you this problem on a real website online?

@mshabarov mshabarov moved this from ✅ Closed to 🔖 High Priority (P1) in Vaadin Flow bugs & maintenance (Vaadin 10+) Jun 13, 2024
@mshabarov mshabarov moved this from Done to 🟢Ready to Go in Vaadin Flow ongoing work (Vaadin 10+) Jun 13, 2024
@mshabarov
Copy link
Contributor

@alexanoid this may give us some insights about use case, but I'd say it's not sufficient to reliably fix the issue, we need a reproducible example.

@alexanoid
Copy link
Author

@mshabarov It looks like the cause of the issue is described here: #19613 Thi is replaceState

@caalador
Copy link
Contributor

@alexanoid can you test with Flow 24.4.6 (It will be in Vaadin 24.4.9 when it comes out) that has the fix for 19613.

@alexanoid
Copy link
Author

@caalador I tried the new version, and the issue disappeared for most pages, but it still reproduces on one of them. I don't quite understand what's special about it; it seems just like the others. I have rolled back to the old version again. Also, the problem from this issue has returned: #18736

@alexanoid
Copy link
Author

alexanoid commented Aug 24, 2024

@caalador I added new issues: #19822 and #19823

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 🅿️Parking lot
Development

No branches or pull requests

5 participants