Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Styling buttons as links #79

Closed
heruan opened this issue Mar 30, 2018 · 4 comments
Closed

Styling buttons as links #79

heruan opened this issue Mar 30, 2018 · 4 comments

Comments

@heruan
Copy link
Member

heruan commented Mar 30, 2018

This is the complementary of https://github.com/vaadin/vaadin-lumo-styles/issues/5 i.e. support for a vaadin-button to appear as a simple link (a). The tertiary theme looks like a link, but it occupies additional space.

@heruan heruan changed the title Style button as link Styling buttons as links Mar 30, 2018
@web-padawan
Copy link
Member

Does the "tertiary-inline" theme variation fit your need? It is now styled to look as part of regular text content, as you can see here.

@heruan
Copy link
Member Author

heruan commented Mar 30, 2018

Oops, I missed that! Yes, it seems to fit exactly what I meant!

@heruan heruan closed this as completed Mar 30, 2018
@web-padawan
Copy link
Member

It used to take some undesired space, actually. This has been fixed in #68. Glad this helped!

@heruan
Copy link
Member Author

heruan commented Mar 31, 2018

Working on vaadin/vaadin-text-field#213 I tried to use a tertiary-inline button instead of a link, but I see it hides the label overflow while a link does not; see https://jsfiddle.net/heruan/h5aksL36/ for example.

screen shot 2018-03-31 at 08 37 36

Would it be acceptable to set overflow: visible on the label part for the tertiary-inline theme?

(This is how it looks with the overflow fix: https://jsfiddle.net/heruan/h5aksL36/3/)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants