Skip to content

Commit

Permalink
test: use fixed overlay height in time-picker visual tests (#8408)
Browse files Browse the repository at this point in the history
  • Loading branch information
web-padawan authored Dec 30, 2024
1 parent f12e44c commit 39242e5
Show file tree
Hide file tree
Showing 6 changed files with 4 additions and 2 deletions.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
3 changes: 2 additions & 1 deletion packages/time-picker/test/visual/lumo/time-picker.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ describe('time-picker', () => {
div.style.display = 'inline-block';
div.style.padding = '10px';
element = fixtureSync('<vaadin-time-picker></vaadin-time-picker>', div);
element.style.setProperty('--vaadin-time-picker-overlay-max-height', '300px');
});

it('basic', async () => {
Expand Down Expand Up @@ -90,7 +91,7 @@ describe('time-picker', () => {
});

it('opened', async () => {
div.style.height = '500px';
div.style.height = '350px';
div.style.width = '200px';
element.click();
await visualDiff(div, `${dir}-opened`);
Expand Down
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ describe('time-picker', () => {
div.style.display = 'inline-block';
div.style.padding = '10px';
element = fixtureSync('<vaadin-time-picker></vaadin-time-picker>', div);
element.style.setProperty('--vaadin-time-picker-overlay-max-height', '300px');
});

it('basic', async () => {
Expand Down Expand Up @@ -90,7 +91,7 @@ describe('time-picker', () => {
});

it('opened', async () => {
div.style.height = '500px';
div.style.height = '350px';
div.style.width = '200px';
element.click();
await visualDiff(div, `${dir}-opened`);
Expand Down

0 comments on commit 39242e5

Please sign in to comment.