refactor: remove iron-resizable-behavior from combo-box (#3195) (#3455)

Co-authored-by: Tomi Virkki <[email protected]>
vaadin · Feb 16, 2022 · 50901fd · 50901fd
1 parent a34e0ef
commit 50901fd
Show file tree

Hide file tree

Showing 5 changed files with 2 additions and 26 deletions.
diff --git a/packages/combo-box/package.json b/packages/combo-box/package.json
@@ -32,7 +32,6 @@
   ],
   "dependencies": {
     "@open-wc/dedupe-mixin": "^1.3.0",
-    "@polymer/iron-resizable-behavior": "^3.0.0",
     "@polymer/polymer": "^3.0.0",
     "@vaadin/component-base": "^22.0.4",
     "@vaadin/field-base": "^22.0.4",

diff --git a/packages/combo-box/src/vaadin-combo-box-dropdown.js b/packages/combo-box/src/vaadin-combo-box-dropdown.js
@@ -6,8 +6,6 @@
 import './vaadin-combo-box-item.js';
 import './vaadin-combo-box-overlay.js';
 import './vaadin-combo-box-scroller.js';
-import { IronResizableBehavior } from '@polymer/iron-resizable-behavior/iron-resizable-behavior.js';
-import { mixinBehaviors } from '@polymer/polymer/lib/legacy/class.js';
 import { html, PolymerElement } from '@polymer/polymer/polymer-element.js';
 
 /**
@@ -16,7 +14,7 @@ import { html, PolymerElement } from '@polymer/polymer/polymer-element.js';
  * @extends HTMLElement
  * @private
  */
-export class ComboBoxDropdown extends mixinBehaviors(IronResizableBehavior, PolymerElement) {
+export class ComboBoxDropdown extends PolymerElement {
   static get is() {
     return 'vaadin-combo-box-dropdown';
   }
@@ -171,14 +169,6 @@ export class ComboBoxDropdown extends mixinBehaviors(IronResizableBehavior, Poly
     this._overlayOpened = false;
   }
 
-  notifyResize() {
-    super.notifyResize();
-
-    if (this.positionTarget && this.opened) {
-      this._setOverlayWidth();
-    }
-  }
-
   _fireTouchAction(sourceEvent) {
     this.dispatchEvent(
       new CustomEvent('vaadin-overlay-touch-action', {

diff --git a/packages/combo-box/src/vaadin-combo-box-mixin.js b/packages/combo-box/src/vaadin-combo-box-mixin.js
@@ -660,8 +660,6 @@ export const ComboBoxMixin = (subclass) =>
 
     /** @private */
     _onOpened() {
-      setTimeout(() => this._resizeDropdown(), 1);
-
       // Defer scroll position adjustment to improve performance.
       requestAnimationFrame(() => {
         this.$.dropdown.adjustScrollPosition();
@@ -842,11 +840,6 @@ export const ComboBoxMixin = (subclass) =>
       }
     }
 
-    /** @private */
-    _resizeDropdown() {
-      this.$.dropdown.notifyResize();
-    }
-
     /** @private */
     _selectedItemChanged(selectedItem) {
       if (selectedItem === null || selectedItem === undefined) {

diff --git a/packages/combo-box/test/combo-box-light.test.js b/packages/combo-box/test/combo-box-light.test.js
@@ -12,6 +12,7 @@ import {
 } from '@vaadin/testing-helpers';
 import { sendKeys } from '@web/test-runner-commands';
 import sinon from 'sinon';
+import '@polymer/polymer/lib/elements/dom-repeat.js';
 import '@vaadin/text-field/vaadin-text-field.js';
 import '@vaadin/polymer-legacy-adapter/template-renderer.js';
 import './not-animated-styles.js';

diff --git a/packages/combo-box/test/filtering.test.js b/packages/combo-box/test/filtering.test.js
@@ -350,13 +350,6 @@ describe('filtering items', () => {
       expect(overlay.hasAttribute('loading')).to.be.false;
     });
 
-    it('should not notify resize the dropdown if not opened', () => {
-      const resizeSpy = sinon.spy(comboBox.$.dropdown, 'notifyResize');
-      comboBox.filteredItems = ['foo', 'bar', 'baz'];
-
-      expect(resizeSpy.called).to.be.false;
-    });
-
     it('should not perform measurements when loading changes if not opened', () => {
       const measureSpy = sinon.spy(comboBox.inputElement, 'getBoundingClientRect');
       comboBox.loading = true;