fix!: always show required field indicator (#3619)

vaadin · Apr 25, 2022 · c20dc46 · c20dc46
1 parent f3863c5
commit c20dc46
Show file tree

Hide file tree

Showing 12 changed files with 1 addition and 6 deletions.
diff --git a/packages/crud/test/visual/lumo/screenshots/crud/baseline/flex-column-layout.png b/packages/crud/test/visual/lumo/screenshots/crud/baseline/flex-column-layout.png
diff --git a/packages/crud/test/visual/lumo/screenshots/crud/baseline/flex-layout.png b/packages/crud/test/visual/lumo/screenshots/crud/baseline/flex-layout.png
diff --git a/...d/test/visual/lumo/screenshots/crud/baseline/ltr-editor-position-aside-edit.png b/...d/test/visual/lumo/screenshots/crud/baseline/ltr-editor-position-aside-edit.png
diff --git a/.../test/visual/lumo/screenshots/crud/baseline/ltr-editor-position-bottom-edit.png b/.../test/visual/lumo/screenshots/crud/baseline/ltr-editor-position-bottom-edit.png
diff --git a/...test/visual/lumo/screenshots/crud/baseline/ltr-editor-position-default-edit.png b/...test/visual/lumo/screenshots/crud/baseline/ltr-editor-position-default-edit.png
diff --git a/...t/visual/lumo/screenshots/crud/baseline/ltr-editor-position-fullscreen-edit.png b/...t/visual/lumo/screenshots/crud/baseline/ltr-editor-position-fullscreen-edit.png
diff --git a/...d/test/visual/lumo/screenshots/crud/baseline/rtl-editor-position-aside-edit.png b/...d/test/visual/lumo/screenshots/crud/baseline/rtl-editor-position-aside-edit.png
diff --git a/.../test/visual/lumo/screenshots/crud/baseline/rtl-editor-position-bottom-edit.png b/.../test/visual/lumo/screenshots/crud/baseline/rtl-editor-position-bottom-edit.png
diff --git a/...test/visual/lumo/screenshots/crud/baseline/rtl-editor-position-default-edit.png b/...test/visual/lumo/screenshots/crud/baseline/rtl-editor-position-default-edit.png
diff --git a/...t/visual/lumo/screenshots/crud/baseline/rtl-editor-position-fullscreen-edit.png b/...t/visual/lumo/screenshots/crud/baseline/rtl-editor-position-fullscreen-edit.png
diff --git a/packages/crud/test/visual/lumo/screenshots/crud/baseline/theme-no-border-edit.png b/packages/crud/test/visual/lumo/screenshots/crud/baseline/theme-no-border-edit.png
diff --git a/packages/vaadin-lumo-styles/mixins/required-field.js b/packages/vaadin-lumo-styles/mixins/required-field.js
@@ -40,21 +40,16 @@ const requiredField = css`
     padding-top: var(--lumo-space-m);
   }
 
-  [part='required-indicator']::after {
+  :host([required]) [part='required-indicator']::after {
     content: var(--lumo-required-field-indicator, '•');
     transition: opacity 0.2s;
-    opacity: 0;
     color: var(--lumo-required-field-indicator-color, var(--lumo-primary-text-color));
     position: absolute;
     right: 0;
     width: 1em;
     text-align: center;
   }
 
-  :host([required]:not([has-value])) [part='required-indicator']::after {
-    opacity: 1;
-  }
-
   :host([invalid]) [part='required-indicator']::after {
     color: var(--lumo-required-field-indicator-color, var(--lumo-error-text-color));
   }