From daa7981df67329a6afb9f4fd6c88274530a9ce7b Mon Sep 17 00:00:00 2001
From: Vaadin Bot <vaadin-bot@users.noreply.github.com>
Date: Thu, 11 Apr 2024 08:44:58 +0200
Subject: [PATCH] fix: set role attribute on the CRUD edit dialog overlay
 (#7310) (#7319)

Co-authored-by: Serhii Kulykov <iamkulykov@gmail.com>
---
 packages/crud/src/vaadin-crud-dialog.js | 1 +
 packages/crud/test/a11y.test.js         | 8 +++++++-
 2 files changed, 8 insertions(+), 1 deletion(-)

diff --git a/packages/crud/src/vaadin-crud-dialog.js b/packages/crud/src/vaadin-crud-dialog.js
index 31b40066337..06a86ccfbe2 100644
--- a/packages/crud/src/vaadin-crud-dialog.js
+++ b/packages/crud/src/vaadin-crud-dialog.js
@@ -145,6 +145,7 @@ class CrudDialog extends DialogBaseMixin(OverlayClassMixin(ThemePropertyMixin(Po
         with-backdrop="[[!modeless]]"
         resizable$="[[resizable]]"
         fullscreen$="[[fullscreen]]"
+        role="dialog"
         focus-trap
       ></vaadin-crud-dialog-overlay>
     `;
diff --git a/packages/crud/test/a11y.test.js b/packages/crud/test/a11y.test.js
index 75b8bff7d8b..97c73e52809 100644
--- a/packages/crud/test/a11y.test.js
+++ b/packages/crud/test/a11y.test.js
@@ -292,7 +292,7 @@ describe('a11y', () => {
     });
   });
 
-  describe('dialog aria-label', () => {
+  describe('dialog ARIA attributes', () => {
     let newButton, editButtons, dialog;
 
     beforeEach(async () => {
@@ -309,6 +309,12 @@ describe('a11y', () => {
       await nextRender();
     });
 
+    it('should set correct role attribute to the dialog overlay', async () => {
+      newButton.click();
+      await nextRender();
+      expect(dialog.$.overlay.getAttribute('role')).to.equal('dialog');
+    });
+
     it('should set correct aria-label to the new item dialog', async () => {
       newButton.click();
       await nextRender();