Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dialog] Align header to the left in case if no title is provided #3669

Closed
web-padawan opened this issue Apr 11, 2022 · 2 comments · Fixed by #3675
Closed

[dialog] Align header to the left in case if no title is provided #3669

web-padawan opened this issue Apr 11, 2022 · 2 comments · Fixed by #3675
Labels
papercuts "Services Papercuts" project theme

Comments

@web-padawan
Copy link
Member

web-padawan commented Apr 11, 2022

Describe your motivation

Originally requested by #3654 (comment) and #3654 (comment)


I would not change the right alignment if used with the title attribute where we can probably 99% agree that the added header information has to be right aligned.

My "problem" comes with the other cases where people wanna use the header with multiple components in a renderer like a flex layout with something like "icon, hx, right aligned buttons" where you don't use title on purpose to allow elements inside the header to be the title. Now you have to make sure to align it to the left on every Dialog you create.

Describe the solution you'd like

Align the header to the left by default and align it to the right if used in conjunction with the title.

@web-padawan web-padawan added theme papercuts "Services Papercuts" project labels Apr 11, 2022
@jouni
Copy link
Member

jouni commented Apr 12, 2022

Sounds like the right approach to me.

@DiegoCardoso
Copy link
Contributor

For the Flow counterpart, we are creating a root element on the server, so that all elements are appended to it. So, essentially, there's a container between the header/footer parts and the child elements added to those parts. I wonder if using display: contents to these container can be used in order to avoid replicating the same behaviour on Dialog for Flow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
papercuts "Services Papercuts" project theme
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants