Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move vaadin-message elements into a slot #4289

Closed
rolfsmeds opened this issue Aug 2, 2022 · 1 comment
Closed

Move vaadin-message elements into a slot #4289

rolfsmeds opened this issue Aug 2, 2022 · 1 comment
Assignees
Labels
refactor Internal improvement requires new major This would be a breaking change v24 To be done in V24 vaadin-messages

Comments

@rolfsmeds
Copy link
Contributor

rolfsmeds commented Aug 2, 2022

Describe your motivation

The vaadin-message elements in the vaadin-message-list component are currently in the component's shadow dom. This presents a challenge for ::part() based styling:

  1. The 8 shadow parts inside vaadin-message need to be propagated to vaadin-message-list using exportparts. That's rather much.
  2. Theme names applied to vaadin-message instances cannot be exposed to the ::part() selector, making it impossible to style messages based on theme using ::part().

Describe the solution you'd like

Move the vaadin-message elements into a slot in vaadin-message-list.

Describe alternatives you've considered

I suppose theme names applied to messages could be reflected as part names.

Additional context

No response

@web-padawan
Copy link
Member

Fixed by #4710

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Internal improvement requires new major This would be a breaking change v24 To be done in V24 vaadin-messages
Projects
None yet
Development

No branches or pull requests

2 participants