Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move avatars in avatar-group into a slot #4291

Closed
rolfsmeds opened this issue Aug 2, 2022 · 0 comments · Fixed by #4723
Closed

Move avatars in avatar-group into a slot #4291

rolfsmeds opened this issue Aug 2, 2022 · 0 comments · Fixed by #4723
Assignees
@web-padawan
Labels
refactor Internal improvement requires new major This would be a breaking change v24 To be done in V24 vaadin-avatar

Comments

@rolfsmeds
Copy link
Contributor

rolfsmeds commented Aug 2, 2022 •
edited
Loading

Describe your motivation

For consistency with other components containing multiple items, especially ones represented by nested web components, which would also make ::part() based styling possible without exportparts, and without exposing the avatars' focus, focus-ring and expanded states as additional part values.

Describe the solution you'd like

Introduce a slot in vaadin-avatar-group and refactor the avatars to be in it instead of in shadow dom.

Describe alternatives you've considered

No response

Additional context

No response
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@web-padawan web-padawan

Labels
refactor Internal improvement requires new major This would be a breaking change v24 To be done in V24 vaadin-avatar
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor!: move vaadin-avatar elements to light DOM vaadin/web-components
2 participants
@rolfsmeds @web-padawan