Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AppLayout marginals look broken on iPhone 15 #8449

Open
mstahv opened this issue Jan 7, 2025 · 4 comments · May be fixed by vaadin/flow#20836
Open

AppLayout marginals look broken on iPhone 15 #8449

mstahv opened this issue Jan 7, 2025 · 4 comments · May be fixed by vaadin/flow#20836
Assignees
Labels
bug Something isn't working Impact: High needs research More information needed to estimate Severity: Minor vaadin-app-layout

Comments

@mstahv
Copy link
Member

mstahv commented Jan 7, 2025

Description

The UX seems to be non-optional when a Vaadin PWA (using AppLayout) is used on modern iPhone. The bottom of the screen is these days rounded and contains the "home swipe icon". Thus the bottom bar has quite little room for view title and buttons/icons. This is not only causing visual issues, but it is also hard to hit the "hamburger icon" in the bottom left corner.

In the attached screenshot it actually looks better than in real life, as the screenshot includes the "hidden pixels" because of rounded screen, but the "home swipe icon" is there. In iPhone, the hamburger icon is right at the edge of the screen and the visible focus ring is cut in half.

IMG_7116

Expected outcome

There should be more marginal for iPhones and other modern smartphones with curved screens.

Minimal reproducible example

Create an app from start.vaadin.com with AppLayout.

Steps to reproduce

Create a Vaadin PWA and open in iPhone

Environment

Vaadin version(s): 24.6.0
OS: iOS (latest)

Browsers

Safari on iOS

@yuriy-fix
Copy link
Contributor

We need to check if iphone safe area is calculated properly within app-layout.

@yuriy-fix yuriy-fix added bug Something isn't working needs research More information needed to estimate Severity: Minor Impact: High vaadin-app-layout labels Jan 9, 2025
@rolfsmeds
Copy link
Contributor

AppLayout should be using the `safe-area-inset-bottom´ environment property to determine how far from the viewport bottom its contents should be. Perhaps that's not working as expected.

Possibly related: safe-area-inset-bottom

@vursen
Copy link
Contributor

vursen commented Jan 13, 2025

I tested the app-layout on iPhone 13 Pro and didn't notice any issues:

ScreenRecording_01-13-2025.14-42-41_1.MP4

Does it look different on iPhone 15?

UPD: My bad, I missed that it required installing the app as a PWA. I can confirm the issue now.

@vursen
Copy link
Contributor

vursen commented Jan 13, 2025

Adding viewport-fit=cover to <meta name="viewport"> seems to fix the issue on iOS.

@vursen vursen self-assigned this Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Impact: High needs research More information needed to estimate Severity: Minor vaadin-app-layout
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants