Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FR - Add a flag to change the default derivation method for Trezor devices #131

Closed
gitmachtl opened this issue Aug 15, 2022 · 6 comments
Closed
Labels
enhancement New feature or request

Comments

@gitmachtl
Copy link
Contributor

As stated in trezor/trezor-firmware#1783 there are a number of different seed derivation schemes used in Cardano. But the 24 word seed implementation had a bug in Trezor. There was a fix for that, and the latest version is using Icarus. However the version with the Bug "Icarus_Legacy" is the default fallback method used in cardano-hw-cli. So if a Trezor device is used with 24 seed words, the derived keys/addresses via cardano-hw-cli don't line up anymore with the ones shown in Trezor-Suite right now. And using addresses generated via hw-cli results in "Cardano Legacy" addresses within Trezor-Suite.

Feature request is to add a flag that would tell cardano-hw-cli to use the newer "Icarus" method and not the "Icarus_Legacy" method.

@refi93

image

@janmazak
Copy link
Collaborator

janmazak commented Sep 1, 2022

@gitmachtl
Well, cardano-hw-cli is a pass-through tool with respect to derivation paths and derived keys, it has no control whatsoever about how keys are derived in the connected HW device (ledger/trezor), and it never derives any keys on its own.

@davidmisiak
Copy link
Collaborator

@janmazak I think we can control the derivation scheme by setting the derivationType parameter on Trezor Connect calls (docs e.g. here).

@gitmachtl
Copy link
Contributor Author

Hmm... i am using trezor-bridge on the cli, is this also available in bridge?

@gitmachtl
Copy link
Contributor Author

gitmachtl commented Sep 1, 2022

@gitmachtl Well, cardano-hw-cli is a pass-through tool with respect to derivation paths and derived keys, it has no control whatsoever about how keys are derived in the connected HW device (ledger/trezor), and it never derives any keys on its own.

I am just wondering how Trezor-Suite can also show the "Ledger" part without knowing the root-key? is Trezor-Suite requesting this from the device in a silenced mode? Or is there also a "Ledger" style flag for the derivationType implemented?

@davidmisiak davidmisiak added the enhancement New feature or request label Sep 13, 2022
@davidmisiak
Copy link
Collaborator

Hmm... i am using trezor-bridge on the cli, is this also available in bridge?

Yes, bridge only forwards commands generated by Trezor Connect.

@davidmisiak
Copy link
Collaborator

Feature added in #135

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants