Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validator does not recognise £ as symbol #2145

Closed
richard-bridgeman opened this issue Jan 11, 2023 · 4 comments
Closed

Validator does not recognise £ as symbol #2145

richard-bridgeman opened this issue Jan 11, 2023 · 4 comments
Labels

Comments

@richard-bridgeman
Copy link

As described in title. ! $ % ^ are recognised but the GBP pound symbol (£) returns false.

Using ReactJS with NextJS 12.

@WikiRik
Copy link
Member

WikiRik commented Jan 11, 2023

Which validator are you using?

@richard-bridgeman
Copy link
Author

@WikiRik the password validator: validator.isStrongPassword

@WikiRik
Copy link
Member

WikiRik commented Jan 11, 2023

The pound sign is indeed not part of the symbol list; https://github.com/validatorjs/validator.js/blob/master/src/lib/isStrongPassword.js#L7

Feel free to open a PR to add this

@pano9000
Copy link
Contributor

Closing, as this is now fixed with commit ee81073 / #2148

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants