Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ValkeyJSON is not RDB compatible with ReJSON 2.8 or later #20

Closed
joehu21 opened this issue Dec 6, 2024 · 3 comments
Closed

ValkeyJSON is not RDB compatible with ReJSON 2.8 or later #20

joehu21 opened this issue Dec 6, 2024 · 3 comments

Comments

@joehu21
Copy link
Collaborator

joehu21 commented Dec 6, 2024

Up to ReJSON v2.6.12, ValkeyJSON is RDB compatible with ReJSON, after issue #19 is resolved. Starting ReJSON v2.8, ReJSON had an RDB format change that broke the compatibility.

Trying to load a ReJSON v2.8.3 RDB using ValkeyJSON:

  7131:M 06 Dec 2024 17:12:06.150 * Module 'json' loaded from /home/jowhuw/github/joehu21-valkeyJSON/build/src/libjson.so
  7131:M 06 Dec 2024 17:12:06.150 * Server initialized
  7131:M 06 Dec 2024 17:12:06.150 # Can't handle RDB format version 12
  7131:M 06 Dec 2024 17:12:06.150 # Fatal error loading the DB, check server logs. Exiting.

Recommendation:
For now, we should at least update our documentation to state that ValkeyJSON is RDB compatible with ReJSON up to v2.6.12. It's unknown if we can still maintain the compatibility with ReJSON v2.8 and later.

@joehu21 joehu21 changed the title ValkeyJSON is no longer RDB compatible with ReJSON 2.8 ValkeyJSON is not RDB compatible with ReJSON 2.8 or later Dec 6, 2024
@roshkhatri
Copy link
Member

Backward compatibility till 2.6.12 is resolved by #19

We need to discuss if we want to be compatible with ReJSON v2.8

@joehu21
Copy link
Collaborator Author

joehu21 commented Dec 18, 2024

This is actually expected. ReJSON v2.8 uses redis 7.2.1. ValkeyJSON makes no commit of RDB compatibility with ReJSON beyond Redis 7.2, which is no longer an open source.

@joehu21
Copy link
Collaborator Author

joehu21 commented Jan 2, 2025

Closed the issue because ValkeyJSON makes no commit of RDB compatibility with ReJSON v2.8 or later that is beyond the last OSS Redis version - 7.1. ValkeyJSON is only RDB-compatible with ReJSON v1.0.8 to v2.6.12.

@joehu21 joehu21 closed this as completed Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants