Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bootstrap 4 and card text #1637

Closed
DouglasWebster opened this issue Feb 13, 2017 · 1 comment
Closed

Bootstrap 4 and card text #1637

DouglasWebster opened this issue Feb 13, 2017 · 1 comment

Comments

@DouglasWebster
Copy link
Contributor

The Bootstrap 4 demo of the ratings module does not layout the text correctly in the card block. It seems that the problem is with including the card and card-block declaration in the same class attribute and then including a tag in the text(see this plunker). Moving the card declaration to its own section solves this.
I'm not sure if it is a problem with Bootstrap or Angular but either way it makes the BS4 version of your demo less attractive.

@valorkin
Copy link
Member

thanks! BTW I will appreciate PR to fix it ;)

https://github.com/valor-software/ng2-bootstrap/tree/development/demo/src/app/components/%2Brating/demos

how to run locally

npm i
npm run build
npm run link
npm start

valorkin pushed a commit that referenced this issue Feb 28, 2017
* Fix Bootstrap 4 and card text #1637

Moved card class to a surrounding div so text formats correctly with Bootstrap 4

* Fix Bootstrap 4 and card text #1637

Moved card class to a surrounding div so text formats correctly with Bootstrap 4
valorkin pushed a commit that referenced this issue Mar 9, 2017
* Fix Bootstrap 4 and card text #1637

Moved card class to a surrounding div so text formats correctly with Bootstrap 4

* Fix Bootstrap 4 and card text #1637

Moved card class to a surrounding div so text formats correctly with Bootstrap 4

* Added instructions for BS4

* Added instructions for BS4 setup with ng/cli

shows how to set up for bootstrap 4 in an angular-cli

* Links added to readme and getting-started for bs4 instructions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants