Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(datepicker): update activeDate on select #1676

Merged
merged 1 commit into from
Mar 1, 2017
Merged

fix(datepicker): update activeDate on select #1676

merged 1 commit into from
Mar 1, 2017

Conversation

fmalcher
Copy link
Contributor

@fmalcher fmalcher commented Feb 22, 2017

I wanted to use angular reactive forms and update the form value from within the component.
However, the date picker does not update its view then. This PR fixes the problem.

I saw there's a new datepicker as work in progress – great! 🎉
Would be nice if you could merge this small fix for the meantime!

Best, Ferdinand

@codecov-io
Copy link

codecov-io commented Feb 22, 2017

Codecov Report

Merging #1676 into development will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           development    #1676   +/-   ##
============================================
  Coverage        84.84%   84.84%           
============================================
  Files               85       85           
  Lines             2323     2323           
  Branches           299      299           
============================================
  Hits              1971     1971           
  Misses             252      252           
  Partials           100      100

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b3fb8d...5be0b32. Read the comment docs.

@valorkin valorkin merged commit 378726b into valor-software:development Mar 1, 2017
@valorkin
Copy link
Member

valorkin commented Mar 1, 2017

Thanks ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants