-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(components): new component loader provided #1318
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
3e53b7d
feat(components): new component loader provided
valorkin a86c340
feat(typeahead): removed old injector usage (#1321)
valorkin 3a0df4c
chore(typeahead): removed usage of component-helper
valorkin 1447fd3
feat(modals): replaced component helper usage with component loader
valorkin 05c74a5
chore(lint): fixed linting issues
valorkin 7cab3a4
chore(tests): WIP
valorkin 5ae0090
chore(tests): compilance tests fixed
valorkin 7cc31d4
Merge branch 'development' into feat-new-component-loader
valorkin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -33,3 +33,6 @@ testem.log | |
#System Files | ||
.DS_Store | ||
Thumbs.db | ||
|
||
src/**/*.js | ||
src/**/*.map |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,7 @@ | ||
The MIT License (MIT) | ||
|
||
Copyright (c) 2015 Valor Software | ||
Copyright (c) 2015 Dmitriy Shekhovtsov<[email protected]> | ||
Copyright (c) 2015-2017 Valor Software | ||
Copyright (c) 2015-2017 Dmitriy Shekhovtsov<[email protected]> | ||
|
||
Permission is hereby granted, free of charge, to any person obtaining a copy | ||
of this software and associated documentation files (the "Software"), to deal | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,20 +1 @@ | ||
Modals are streamlined, but flexible, dialog prompts with the minimum required functionality and smart defaults. | ||
|
||
Base specifications: [bootstrap 3](http://getbootstrap.com/javascript/#modals) or [bootstrap 4](http://v4-alpha.getbootstrap.com/components/modal/) | ||
|
||
### **Important notes**: | ||
- Don't forget to add `hack` to your application root component ([why?](https://github.com/angular/angular/issues/6446#issuecomment-173459525)) | ||
|
||
```typescript | ||
import { Component, ViewContainerRef } from '@angular/core'; | ||
|
||
@Component({selector:'app-root'}) | ||
class AppRoot { | ||
protected viewContainerRef: ViewContainerRef; | ||
|
||
public constructor(viewContainerRef:ViewContainerRef) { | ||
// You need this small hack in order to catch application root view container ref | ||
this.viewContainerRef = viewContainerRef; | ||
} | ||
} | ||
``` |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,10 +1,16 @@ | ||
// Typings reference file, you can add your own global typings here | ||
// https://www.typescriptlang.org/docs/handbook/writing-declaration-files.html | ||
|
||
// tslint:disable | ||
declare const System: any; | ||
declare const ENV:string; | ||
// google code-prettify | ||
declare const PR:any; | ||
|
||
declare const require:any; | ||
declare const global:any; | ||
|
||
declare module jasmine { | ||
interface Matchers { | ||
toHaveCssClass(expected: any): boolean; | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
// tslint:disable | ||
/** | ||
* @copyright Angular ng-bootstrap team | ||
*/ | ||
beforeEach(() => { | ||
jasmine.addMatchers({ | ||
toHaveCssClass(/*util, customEqualityTests*/) { | ||
return {compare: buildError(false), negativeCompare: buildError(true)}; | ||
|
||
function buildError(isNot) { | ||
return function (actual, className) { | ||
const orNot = isNot ? 'not ' : ''; | ||
return { | ||
pass: actual.classList.contains(className) === !isNot, | ||
message: `Expected ${actual.outerHTML} ${orNot} to contain the CSS class "${className}"` | ||
}; | ||
}; | ||
} | ||
} | ||
}); | ||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,9 +1,17 @@ | ||
// Typings reference file, you can add your own global typings here | ||
// https://www.typescriptlang.org/docs/handbook/writing-declaration-files.html | ||
|
||
// tslint:disable | ||
|
||
declare const System: any; | ||
declare const ENV:string; | ||
// google code-prettify | ||
declare const PR:any; | ||
|
||
declare const global:any; | ||
|
||
declare module jasmine { | ||
interface Matchers { | ||
toHaveCssClass(expected: any): boolean; | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
Sorry, something went wrong.