Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modal not showing, because bootstrap renamed fade.in to fade.active #1190

Closed
Gillardo opened this issue Nov 1, 2016 · 2 comments
Closed

Comments

@Gillardo
Copy link
Contributor

Gillardo commented Nov 1, 2016

As the title says, i have downloaded the latest version of bootstrap 4 from the v4-dev branch along with the latest version of ng2-bootstrap and none of my modal windows are displaying. After checking the elements, the modal window is there, but the fade.in css class has been removed from bootstrap and has been renamed to fade.active

.fade.in {
opacity: 1;
}

CHANGED TO

.fade.active {
opacity: 1;
}

@valorkin
Copy link
Member

valorkin commented Nov 2, 2016

Nice reason for small PR changing bs4 template

@Gillardo
Copy link
Contributor Author

Gillardo commented Nov 3, 2016

Happy to make the PR, but question. Readme says that this should all work bs3 and bs4. Is there anywhere that the user sets this, as to whether they are using bs3 or bs4, or do you just add the classes for both when applying css to elements?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants