Done: Please add support for Angular 4

[vinothsubramanian]

Currently when updating to angular 4 we are getting the below warning:

npm WARN [email protected] requires a peer of @angular/common@^2.3.1 but none was installed.
npm WARN [email protected] requires a peer of @angular/compiler@^2.3.1 but none was installed.
npm WARN [email protected] requires a peer of @angular/core@^2.3.1 but none was installed.
npm WARN [email protected] requires a peer of @angular/forms@^2.3.1 but none was installed.

[narainsagar]

Hello, I'm going to open a PR for this!

[valorkin]

It is already available in @beta version

[St1c]

I tried the beta, but it seems that it relies on angular RC, but stable is already out there.

[valorkin]

Ignore this, it is just a peer dependencies

[Ketec]

Could simply relax peer dep to >=4.0.0

[FabienDehopre]

alos, don't forget to replace <template> tags by <ng-template>.

[valorkin]

I don't want to drop backwards compatibility :(

[GuskiS]

Well, I think you should cut a version where you stop worry about Angular2 and focus on Angular4. @valorkin

[conor-mac-aoidh]

@valorkin 4.0.0 is out - could you update @beta version to use the stable ng 4 release?

The peer dependency breaks compatibility with npm shrinkwrap for those on ng 4.0.0.

[valorkin]

Yep, I will cut down 2 versions tomorrow

[valorkin]

With new dropdown and ng v4

[am-hs]

Can we use ">2.0.0" instead of "^4.0.0" to avoid this issue in future angular versions?

[Ketec]

What about: "^2.0.0" || ">4.0.0"
So 2 and 4 both are supported, may be deprecated but for now it still works.

[eestein]

Adding to @FabienDehopre using ng-template would be nice. The only warning I receive atm is from ng2-bootstrap:

The <template> element is deprecated. Use <ng-template> instead ("
[WARNING ->]<template [ngIf]="!isClosed">
  <div [class]="'alert alert-' + type" role="alert" [ngClass]="classes""): ng:///projx/node_modules/ng2-bootstrap/alert/alert.component.d.ts.AlertComponent.html@1:0

Thanks :)

[Martin-Luft]

@eestein this is already done in ^2.0.0-rc.0 :)

[Ketec]

Do not see tag 2.0.0-rc.0 - latest i see is 1.4.2

[Martin-Luft]

@Ketec npm install [email protected] ;)

[eestein]

@Martin-Wegner thanks :) I'll try that

[GuskiS]

@Martin-Wegner Where is the branch of 2.0.0? 🤔
@valorkin Also, do you plan to change the name of package?

[Martin-Luft]

@GuskiS I don't know which branch @valorkin used :/
And renaming is discussed here: #1280

[valorkin]

ngx-bootstrap will be the new name

[valorkin]

v1.6 with relaxed peer dependencies published

[rerickson1]

Just tried v1.6 and I can confirm it fixes npm shrinkwrap

[St1c]

but it doesn't use <ng-template> :)

[Martin-Luft]

@St1c this is because @valorkin did not want to break Angular 2 support.

[valorkin]

Guilty, things: renaming templates is only 15% of migration for me, internal stuff changed too. So I will have update services too

[harunurhan]

why not support Angular 4 properly (with <ng-template>) and do a major release? @valorkin

[valorkin]

Check @next version in npm

[ojourmel]

@next version is only available for ng2-bootstrap, not ngx-bootstrap. Would it be possible to publish @next for ngx-bootstrap?

$ npm view ngx-bootstrap dist-tags
{ latest: '1.6.2' }

$ npm view ng2-bootstrap dist-tags
{ latest: '1.6.2', next: '2.0.0-beta.0' }

---

edit as of April 17th
Looks good!

$ npm view ngx-bootstrap dist-tags
{ latest: '1.6.6', next: '2.0.0-beta.2' }

[H--o-l]

@valorkin Hello ! Can you tell me the branch to use if I want to look at the code or contribute to @next version ?

[qvidmi]

+1, @valorkin , can you please share with us where can we find code related to @next version?

[MacKinley]

+1 @valorkin, yes please share the source to the @next version.
I get the Cannot call a namespace ('moment') error with @next version with Angular4 when running AOT compiling and rollup.
Adding "allowSyntheticDefaultImports": true as mentioned in #1556 my tsconfig.json had no effect. Maybe I am doing something wrong there.

I actually use moment in my application directly and solved this issue by using moment-es6 Referenced here. I assume doing something similar in the @next version might solve this issue.