Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(1556): refix issue with moment import #2023

Merged
merged 1 commit into from
Jun 15, 2017
Merged

fix(1556): refix issue with moment import #2023

merged 1 commit into from
Jun 15, 2017

Conversation

sebek64
Copy link
Contributor

@sebek64 sebek64 commented Jun 2, 2017

 - this was issue 1556, broken by 27a0229
@codecov
Copy link

codecov bot commented Jun 2, 2017

Codecov Report

Merging #2023 into development will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #2023   +/-   ##
============================================
  Coverage        86.54%   86.54%           
============================================
  Files               85       85           
  Lines             2252     2252           
  Branches           290      290           
============================================
  Hits              1949     1949           
  Misses             203      203           
  Partials           100      100

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dab394c...ea3bc42. Read the comment docs.

@valorkin
Copy link
Member

valorkin commented Jun 2, 2017

this is most changed line in this lib ;)
what works fine for one, doesn't work for another ;(

@sebek64
Copy link
Contributor Author

sebek64 commented Jun 2, 2017

Hm, after some investigation, it seems that there is no good solution. The current state (1.7.0) is the way momentjs authors recommend. However, it is broken for Rollup users (or any ES6-module users in general). Is there any reason the import was changed back in the 1.7 version? I can't find it from the git changes, it is just part of a big commit.

@valorkin
Copy link
Member

valorkin commented Jun 6, 2017

@sebek64 I asked guys to add snowlake to ngx-bootstrap
so I could test build on rollup\gulp\system.js on each build

@valorkin valorkin merged commit 8ed0c06 into valor-software:development Jun 15, 2017
@sebek64 sebek64 deleted the fix-1556-again branch June 15, 2017 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants