fix(typeahead): Fix crash on Firefox and contenteditable input
#2057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## development #2057 +/- ##
===============================================
- Coverage 87.13% 87.09% -0.04%
===============================================
Files 85 85
Lines 2262 2263 +1
Branches 292 293 +1
===============================================
Hits 1971 1971
- Misses 188 189 +1
Partials 103 103
Continue to review full report at Codecov.
|
valorkin
added
comp(typeahead)
needs review
ready for tests
and removed
needs review
labels
When using the typeahead directive on a `contenteditable` input, crashes
can happen on Firefox:
TypeError
n.target.innerText is undefined
According to many sources [1] [2] [3], `innerText` should only be used
on old browsers where `textContent` in not defined (e.g. Internet
Explorer). On newer browsers that abide by standards, `textContent` is
the right property to use to avoid problems.
[1]: https://stackoverflow.com/a/22990890
[2]: https://teamtreehouse.com/community/firefox-innertext-undefined-teachers-note
[3]: https://developer.mozilla.org/en-US/docs/Web/API/Node/textContent
adrienverge
force-pushed
the
fix/typeahead/typeerror-on-firefox
branch
from
6e6e703 to
bd9a13d
Compare
|
@valorkin I rebased on latest |
|
Thanks for PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the typeahead directive on a
contenteditableinput, crashes can happen on Firefox:According to many sources [1] [2] [3],
innerTextshould only be used on old browsers wheretextContentin not defined (e.g. Internet Explorer). On newer browsers that abide by standards,textContentis the right property to use to avoid problems.[1]: https://stackoverflow.com/a/22990890
[2]: https://teamtreehouse.com/community/firefox-innertext-undefined-teachers-note
[3]: https://developer.mozilla.org/en-US/docs/Web/API/Node/textContent