Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(modal): add modal service events, fix modal content onDestroy [fixes #2256] #2272

Merged
merged 1 commit into from
Jul 26, 2017

Conversation

IlyaSurmay
Copy link
Contributor

@IlyaSurmay IlyaSurmay commented Jul 25, 2017

closes #2268

@IlyaSurmay IlyaSurmay requested a review from valorkin July 25, 2017 11:58
@codecov
Copy link

codecov bot commented Jul 25, 2017

Codecov Report

Merging #2272 into development will decrease coverage by 0.06%.
The diff coverage is 0%.

Impacted file tree graph

@@              Coverage Diff               @@
##           development   #2272      +/-   ##
==============================================
- Coverage        87.46%   87.4%   -0.07%     
==============================================
  Files               95      95              
  Lines             2681    2683       +2     
  Branches           358     359       +1     
==============================================
  Hits              2345    2345              
- Misses             214     215       +1     
- Partials           122     123       +1
Impacted Files Coverage Δ
src/component-loader/component-loader.class.ts 77.04% <0%> (-1.29%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64793c2...37a9144. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modal service: return promise with corresponding event
3 participants