-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fixed bug]: Added null check on the parentElement in focusOtherModal() #2612
Conversation
Codecov Report
@@ Coverage Diff @@
## development #2612 +/- ##
===============================================
- Coverage 65.99% 65.98% -0.02%
===============================================
Files 182 182
Lines 5011 5012 +1
Branches 790 791 +1
===============================================
Hits 3307 3307
- Misses 1391 1392 +1
Partials 313 313
Continue to review full report at Codecov.
|
I'm experiencing the same error. Please merge. |
@IlyaSurmay Can you release it to version 1.9.3? This issue was introduced 13 july and I have verified that this commit solves the issue. |
Same issue here. I'm using version 1.9.3 |
@IlyaSurmay please resolve conflicts and push to new branch, so we can merge |
@mario-siama thanks again! |
just so you know what we were doing lately :) |
Thank you! Is it possible to merge into 1.9.4 so we don't need to use beta version? |
If the modal is created without parent, the console will display error on closing function: