feat(bdd): add bdd support #3026

YevheniiaMazur · 2017-11-11T07:54:38Z

PR Checklist

Before creating new PR, please take a look at checklist below to make sure that you've done everything that needs to be done before we can merge it.

read and followed the CONTRIBUTING.md guide.
built and tested the changes locally.
added/updated tests.
added/updated API documentation.
added/updated demos.

codecov · 2017-11-11T08:15:00Z

Codecov Report

Merging #3026 into development will increase coverage by 0.44%.
The diff coverage is n/a.

@@               Coverage Diff               @@
##           development    #3026      +/-   ##
===============================================
+ Coverage        65.49%   65.94%   +0.44%     
===============================================
  Files              207      207              
  Lines             5597     5552      -45     
  Branches           985      874     -111     
===============================================
- Hits              3666     3661       -5     
- Misses            1669     1696      +27     
+ Partials           262      195      -67

Impacted Files	Coverage Δ
src/index.ts	`100% <0%> (ø)`	⬆️
demo/src/app/app.component.ts	`34.28% <0%> (ø)`	⬆️
...ker/themes/bs/bs-datepicker-container.component.ts	`38.7% <0%> (ø)`	⬆️
...c/datepicker/bs-daterangepicker-input.directive.ts	`29.09% <0%> (ø)`	⬆️
src/modal/bs-modal.service.ts	`22.85% <0%> (ø)`	⬆️
src/sortable/index.ts	`100% <0%> (ø)`	⬆️
src/datepicker/reducer/bs-datepicker.effects.ts	`17.64% <0%> (ø)`	⬆️
...hemes/bs/bs-daterangepicker-container.component.ts	`30.76% <0%> (ø)`	⬆️
...themes/bs/bs-datepicker-day-decorator.directive.ts	`100% <0%> (ø)`	⬆️
src/datepicker/bs-datepicker-input.directive.ts	`32.65% <0%> (ø)`	⬆️
... and 28 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d97211b...88db5da. Read the comment docs.

codecov-io · 2017-11-14T16:28:18Z

Codecov Report

Merging #3026 into development will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           development    #3026   +/-   ##
============================================
  Coverage        65.04%   65.04%           
============================================
  Files              210      210           
  Lines             5690     5690           
  Branches           999      999           
============================================
  Hits              3701     3701           
  Misses            1724     1724           
  Partials           265      265

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a7f2f0...4dbc080. Read the comment docs.

package.json

@@ -105,6 +109,7 @@
    "core-js": "2.5.1",
    "cpy": "5.1.0",
    "cpy-cli": "1.0.1",
+    "cucumber": "^3.1.0",


demo/e2e-bdd/shared/helpers/wd-helper.ts

+  const elemPosition = await button.getLocation();
+  if (elemPosition.y > viewPortBorders.height) {
+    await browser.executeScript(function () {
+      return arguments[0].scrollIntoView();


demo/e2e-bdd/shared/helpers/wd-helper.ts

+  let page;
+
+  switch (componentName) {
+    case 'Getting Started': {


protractor.cucumber.js

@@ -0,0 +1,48 @@
+var envUrl =  "http://ngx-bootstrap-latest.surge.sh/#/";


protractor.cucumber.js

+}
+
+if(process.env.TRAVIS) {
+  envUrl = "http://localhost:3000/"


protractor.cucumber.js

+  },
+
+  onPrepare: () => {
+  require('ts-node').register({project: 'demo/e2e-bdd'});


YevheniiaMazur added needs review WIP labels Nov 11, 2017

YevheniiaMazur requested a review from valorkin November 11, 2017 07:54

valorkin changed the title ~~feat(bdd): add bdd support~~ WIP feat(bdd): add bdd support Nov 11, 2017

YevheniiaMazur force-pushed the feat-add-bdd-support branch 20 times, most recently from 88db5da to eecb039 Compare November 14, 2017 16:28

YevheniiaMazur force-pushed the feat-add-bdd-support branch 4 times, most recently from 98d493f to 663b29c Compare November 16, 2017 13:27

YevheniiaMazur force-pushed the feat-add-bdd-support branch from 2e067d1 to 6132334 Compare December 5, 2017 12:21

ghost added the in progress label Dec 5, 2017

YevheniiaMazur removed the in progress label Dec 5, 2017

valburyakov reviewed Dec 5, 2017

View reviewed changes

package.json Outdated

@@ -105,6 +109,7 @@

"core-js": "2.5.1",

"cpy": "5.1.0",

"cpy-cli": "1.0.1",

"cucumber": "^3.1.0",

This comment was marked as off-topic.

Sign in to view

YevheniiaMazur force-pushed the feat-add-bdd-support branch from 48ea48a to 8b5df8a Compare December 5, 2017 15:12

ghost added the in progress label Dec 5, 2017

YevheniiaMazur removed the in progress label Dec 5, 2017

YevheniiaMazur force-pushed the feat-add-bdd-support branch from 8b5df8a to bd07ecb Compare December 5, 2017 16:32

ghost added the in progress label Dec 5, 2017

YevheniiaMazur force-pushed the feat-add-bdd-support branch 2 times, most recently from 4213bd0 to bfec46b Compare December 5, 2017 17:59

YevheniiaMazur removed the in progress label Dec 6, 2017

valorkin requested changes Dec 6, 2017

View reviewed changes

YevheniiaMazur force-pushed the feat-add-bdd-support branch from bfec46b to 7792255 Compare December 6, 2017 14:13

ghost added the in progress label Dec 6, 2017

YevheniiaMazur force-pushed the feat-add-bdd-support branch from 7792255 to 881980b Compare December 6, 2017 14:16

YevheniiaMazur removed the in progress label Dec 6, 2017

YevheniiaMazur force-pushed the feat-add-bdd-support branch from 881980b to 0512bb7 Compare December 7, 2017 10:18

ghost added the in progress label Dec 7, 2017

YevheniiaMazur removed the in progress label Dec 7, 2017

valorkin requested changes Dec 7, 2017

View reviewed changes

YevheniiaMazur force-pushed the feat-add-bdd-support branch from 0512bb7 to 4c63ff1 Compare December 7, 2017 12:05

ghost added the in progress label Dec 7, 2017

YevheniiaMazur removed the in progress label Dec 7, 2017

feat(tests): covering navigation feature with bdd

4dbc080

YevheniiaMazur force-pushed the feat-add-bdd-support branch from 4c63ff1 to 4dbc080 Compare December 7, 2017 12:18

ghost added the in progress label Dec 7, 2017

YevheniiaMazur removed the in progress label Dec 7, 2017

valorkin merged commit c5fb8dc into development Dec 7, 2017

valorkin deleted the feat-add-bdd-support branch December 7, 2017 15:28

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(bdd): add bdd support #3026

feat(bdd): add bdd support #3026

YevheniiaMazur commented Nov 11, 2017

codecov bot commented Nov 11, 2017 •

edited

Loading

codecov-io commented Nov 14, 2017 •

edited by codecov bot

Loading

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

		@@ -0,0 +1,48 @@
		var envUrl = "http://ngx-bootstrap-latest.surge.sh/#/";

feat(bdd): add bdd support #3026

feat(bdd): add bdd support #3026

Conversation

YevheniiaMazur commented Nov 11, 2017

PR Checklist

codecov bot commented Nov 11, 2017 • edited Loading

Codecov Report

codecov-io commented Nov 14, 2017 • edited by codecov bot Loading

Codecov Report

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

codecov bot commented Nov 11, 2017 •

edited

Loading

codecov-io commented Nov 14, 2017 •

edited by codecov bot

Loading