Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(datepicker): fixed viewed date if min max is set #3129

Merged
merged 1 commit into from
Nov 28, 2017

Conversation

valorkin
Copy link
Member

if no date is selected and min or max dates are excluding current month
show minimal or maximal provided date

fixes #3123 fixes #2711

@valorkin valorkin added this to the v2.0.0 milestone Nov 28, 2017
@ghost ghost assigned valorkin Nov 28, 2017
@valorkin valorkin force-pushed the feat-datepicker-fix-min-max-view-date branch from f3522ef to 52865f5 Compare November 28, 2017 14:46
if no date is selected and min or max dates are excluding current month
show minimal or maximal provided date

fixes #3123 fixes #2711
@valorkin valorkin force-pushed the feat-datepicker-fix-min-max-view-date branch from 52865f5 to 531b7cb Compare November 28, 2017 14:47
@codecov
Copy link

codecov bot commented Nov 28, 2017

Codecov Report

Merging #3129 into development will decrease coverage by 0.08%.
The diff coverage is 29.41%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #3129      +/-   ##
===============================================
- Coverage        65.31%   65.23%   -0.09%     
===============================================
  Files              209      209              
  Lines             5628     5635       +7     
  Branches           990      993       +3     
===============================================
  Hits              3676     3676              
- Misses            1689     1696       +7     
  Partials           263      263
Impacted Files Coverage Δ
src/datepicker/reducer/bs-datepicker.reducer.ts 12.82% <29.41%> (-0.82%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9822f0...531b7cb. Read the comment docs.

@YevheniiaMazur
Copy link

Tested, looks good

@valorkin valorkin merged commit 13bf18e into development Nov 28, 2017
@valorkin valorkin deleted the feat-datepicker-fix-min-max-view-date branch November 28, 2017 15:24
@ghost ghost removed the ready for merge label Nov 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants