Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Throwing error rather than panic in ExecuteFuncString #17

Open
lext-7 opened this issue Apr 9, 2019 · 1 comment
Open

Throwing error rather than panic in ExecuteFuncString #17

lext-7 opened this issue Apr 9, 2019 · 1 comment

Comments

@lext-7
Copy link

lext-7 commented Apr 9, 2019

I found that if ExecuteFunc returns an error, ExecuteFuncString will use panic. I think returning an error is more reasonable.
See https://github.com/valyala/fasttemplate/blob/master/template.go#L91
@storyicon
Copy link

use ExecuteFuncStringWithErr instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lext-7 @storyicon