Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make previously public code public again #465

Merged
merged 4 commits into from
Jun 18, 2024

Conversation

holtgrewe
Copy link
Contributor

No description provided.

@holtgrewe holtgrewe requested a review from tedil June 17, 2024 11:36
Copy link

codecov bot commented Jun 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.64%. Comparing base (83b47d3) to head (e37c50a).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #465   +/-   ##
=======================================
  Coverage   75.64%   75.64%           
=======================================
  Files          24       24           
  Lines        8576     8576           
=======================================
  Hits         6487     6487           
  Misses       2089     2089           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

tedil
tedil previously approved these changes Jun 17, 2024
Copy link
Contributor

@tedil tedil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (but I did add a comment w.r.t. to async_trait as a reminder)

src/annotate/seqvars/mod.rs Outdated Show resolved Hide resolved
@holtgrewe holtgrewe merged commit 0ef7652 into main Jun 18, 2024
6 checks passed
@holtgrewe holtgrewe deleted the fix-make-stuff-public-again branch June 18, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants