Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ui/menu): replace menuV2 with menu #690

Merged
merged 1 commit into from
Sep 14, 2022
Merged

refactor(ui/menu): replace menuV2 with menu #690

merged 1 commit into from
Sep 14, 2022

Conversation

wangKBweb
Copy link
Member

Checklist


  • Fix linting errors
  • Tests have been added / updated (or snapshots)

Change information


@vercel
Copy link

vercel bot commented Sep 13, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
varlet ✅ Ready (Inspect) Visit Preview Sep 13, 2022 at 2:54PM (UTC)
varlet-ui-playground ✅ Ready (Inspect) Visit Preview Sep 13, 2022 at 2:54PM (UTC)

@codecov-commenter
Copy link

Codecov Report

Merging #690 (66f6750) into v2.0 (6693c6d) will decrease coverage by 0.08%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             v2.0     #690      +/-   ##
==========================================
- Coverage   79.51%   79.43%   -0.09%     
==========================================
  Files         240      237       -3     
  Lines        4941     4886      -55     
  Branches     1003      997       -6     
==========================================
- Hits         3929     3881      -48     
+ Misses        200      197       -3     
+ Partials      812      808       -4     
Impacted Files Coverage Δ
packages/varlet-ui/src/menu/index.ts 100.00% <ø> (ø)
packages/varlet-ui/src/select/Select.vue 80.46% <ø> (ø)
packages/varlet-ui/src/menu/Menu.vue 77.57% <100.00%> (ø)
packages/varlet-ui/src/menu/props.ts 100.00% <100.00%> (ø)
packages/varlet-ui/src/utils/components.ts 81.25% <0.00%> (-1.79%) ⬇️
packages/varlet-ui/src/utils/elements.ts 67.36% <0.00%> (-1.06%) ⬇️
...kages/varlet-ui/src/collapse-item/CollapseItem.vue 78.00% <0.00%> (+4.00%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@haoziqaq haoziqaq merged commit bb21ae3 into varletjs:v2.0 Sep 14, 2022
BeADre pushed a commit that referenced this pull request Sep 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants