Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow passing props to material-ui's InputLabel #481

Closed
Floriferous opened this issue Nov 1, 2018 · 2 comments
Closed

Allow passing props to material-ui's InputLabel #481

Floriferous opened this issue Nov 1, 2018 · 2 comments
Assignees
Labels
Type: Feature New features and feature requests

Comments

@Floriferous
Copy link
Contributor

We're using the material-ui variant of uniforms, and we've had the issue where we want to use displayEmpty of the Select, which conflicts with the InputLabel, as can be seen in this issue: mui/material-ui#12336

The shrink prop on InputLabel would fix it, but there's currently no way to customize it, as all SelectField props are spread on the Select component only.

Not sure what's best, picking all props that should be on InputLabel (shrink required disableAnimation for example), or spread a new prop labelProps ?

@radekmie radekmie self-assigned this Nov 2, 2018
@radekmie radekmie added the Type: Feature New features and feature requests label Nov 2, 2018
@radekmie
Copy link
Contributor

radekmie commented Nov 2, 2018

Hi @Floriferous. Sounds good, as long as each InputLabel will be handled, not only the SelectField one. In this case, labelProps would be better, as there might be conflicts in prop names. Would you like to submit a PR for that?

@radekmie
Copy link
Contributor

Closed in #485.

@radekmie radekmie moved this to Closed in Open Source Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature New features and feature requests
Projects
Archived in project
Development

No branches or pull requests

2 participants