Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 修复index.html加载文字偏移的问题 #3306

Merged
merged 1 commit into from
Nov 21, 2023
Merged

fix: 修复index.html加载文字偏移的问题 #3306

merged 1 commit into from
Nov 21, 2023

Conversation

xachary
Copy link

@xachary xachary commented Nov 20, 2023

General

✏️ 仔细看初次加载/刷新点时候,加载图标下面的文字,在即将跳转到时候会向上抖几个像素,强迫症都犯了。

  • Pull request template structure not broken

Type

ℹ️ What types of changes does your code introduce?

👉 Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

ℹ️ Check all checkboxes - this will indicate that you have done everything in accordance with the rules in CONTRIBUTING.

👉 Put an x in the boxes that apply.

  • My code follows the style guidelines of this project
  • Is the code format correct
  • Is the git submission information standard?
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@zwtvip
Copy link

zwtvip commented Nov 20, 2023

这个加在公共样式文件里比较好吧

@xachary
Copy link
Author

xachary commented Nov 20, 2023

@zwtvip 这个时候可能还没来得及呢,如果可以你可以加,然后我们pull update一下就好,效果一样就行。

@likui628 likui628 merged commit c715d35 into vbenjs:main Nov 21, 2023
2 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants