Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 设置 baseurl 后不生效的问题 #3318

Merged
merged 2 commits into from
Nov 23, 2023
Merged

fix: 设置 baseurl 后不生效的问题 #3318

merged 2 commits into from
Nov 23, 2023

Conversation

xingyuv
Copy link

@xingyuv xingyuv commented Nov 22, 2023

General

✏️ Mark the necessary items without changing the structure of the PR template.

  • Pull request template structure not broken

Type

ℹ️ What types of changes does your code introduce?

👉 Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

ℹ️ Check all checkboxes - this will indicate that you have done everything in accordance with the rules in CONTRIBUTING.

👉 Put an x in the boxes that apply.

  • My code follows the style guidelines of this project
  • Is the code format correct
  • Is the git submission information standard?
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@wangjue666
Copy link
Collaborator

提供个复现

@xingyuv
Copy link
Author

xingyuv commented Nov 22, 2023

提供个复现

设置一下 VITE_PUBLIC_PATH = /test

然后直接 pnpm preview 就可以复现了

@wangjue666
Copy link
Collaborator

然后直接 pnpm preview 就可以复现了

只是preview下编译的情况会出现这个问题吗

@xingyuv
Copy link
Author

xingyuv commented Nov 23, 2023

然后直接 pnpm preview 就可以复现了

只是preview下编译的情况会出现这个问题吗

编译后部署到服务器中也会出现

@wangjue666 wangjue666 merged commit 4305f58 into vbenjs:main Nov 23, 2023
2 checks passed
@xingyuv xingyuv deleted the x-dev branch November 23, 2023 09:44
@github-actions github-actions bot locked and limited conversation to collaborators Aug 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants