Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deduplicate server logic in vectara-answer #46

Open
cjcenizal opened this issue Aug 10, 2023 · 0 comments
Open

Deduplicate server logic in vectara-answer #46

cjcenizal opened this issue Aug 10, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@cjcenizal
Copy link
Collaborator

We can update package.json scripts with this:

"serve": "node docker/server/index.js",

This will enable us to remove the server/ directory. We'll just need to update the serve script to also provide a command-line argument and then update docker/server/index.js to use that argument to conditionally set the port, the location of the build directory, and maybe some other things.

@cjcenizal cjcenizal added the enhancement New feature or request label Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant