Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Homeserver version parser should support version without patch #6017

Closed
bmarty opened this issue May 10, 2022 · 0 comments · Fixed by #6214
Closed

Homeserver version parser should support version without patch #6017

bmarty opened this issue May 10, 2022 · 0 comments · Fixed by #6214
Assignees
@ouchadam
Labels
matrix-sdk T-Defect Something isn't working: bugs, crashes, hangs and other reported problems T-Task Refactoring, enabling or disabling functionality, other engineering tasks

Comments

@bmarty
Copy link
Member

bmarty commented May 10, 2022

For instance v1.4 should be correctly parsed, currently only v1.4.0 will work.

The code is here: https://github.com/vector-im/element-android/blob/main/matrix-sdk-android/src/main/java/org/matrix/android/sdk/internal/auth/version/HomeServerVersion.kt#L41

Also discussed in #5997

Also required to close this issue: add some unit tests on the parser (could candidate for TDD).
@bmarty bmarty added T-Defect Something isn't working: bugs, crashes, hangs and other reported problems T-Task Refactoring, enabling or disabling functionality, other engineering tasks labels May 10, 2022
@ouchadam ouchadam self-assigned this May 31, 2022
@ouchadam ouchadam mentioned this issue May 31, 2022
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ouchadam ouchadam

Labels
matrix-sdk T-Defect Something isn't working: bugs, crashes, hangs and other reported problems T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Homeserver version without patch number parsing element-hq/element-android
2 participants
@ouchadam @bmarty