Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Share extension does not fully respect themes other than Light #3029

Closed
GrigoryPtashko opened this issue Mar 13, 2020 · 2 comments · Fixed by #6337
Closed

Share extension does not fully respect themes other than Light #3029

GrigoryPtashko opened this issue Mar 13, 2020 · 2 comments · Fixed by #6337
Labels
A-ShareExtension O-Occasional Affects or can be seen by some users regularly or most users rarely S-Tolerable Low/no impact on users T-Defect Something isn't working: bugs, crashes, hangs and other reported problems

Comments

@GrigoryPtashko
Copy link

GrigoryPtashko commented Mar 13, 2020 •
edited by pixlwave
Loading

Working on the #3012 I've tried to change the theme for the Share extension. It it turned out that it is somewhere light and somewhere dark. I guess this should be a separate issue.

Old Share Extension Old Share Extension
Simulator Screen Shot - iPhone Xs Max - 2020-03-13 at 13 15 55 Simulator Screen Shot - iPhone Xs Max - 2020-03-13 at 13 15 50
@domoritz
Copy link

I think this has been fixed. At least the share extension works for me in dark and light mode now.

@pixlwave
Copy link
Member

There appears to be a small issue with the safe area remaining:
IMG_B9BBBE9E0DAE-1

@pixlwave pixlwave added A-ShareExtension O-Occasional Affects or can be seen by some users regularly or most users rarely S-Tolerable Low/no impact on users T-Defect Something isn't working: bugs, crashes, hangs and other reported problems labels Jan 27, 2022
@pixlwave pixlwave mentioned this issue Jun 23, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-ShareExtension O-Occasional Affects or can be seen by some users regularly or most users rarely S-Tolerable Low/no impact on users T-Defect Something isn't working: bugs, crashes, hangs and other reported problems
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix share extension background in dark mode. element-hq/element-ios
3 participants
@domoritz @GrigoryPtashko @pixlwave