Some links inside messages are rendered as “in reply to”

[ShadowJonathan]

Full source;

Code

{
  "sender" : "@rss:maunium.net",
  "content" : {
    "body" : "> <@tulir:maunium.net> !rss subscriptions\n\n**Subscriptions in this room:**\n\n● 224 - Element Blog (https:\/\/element.io\/blog\/rss\/) (subscribed by @tulir:maunium.net)\n    ⚠️ The last 23 attempts to fetch the feed have failed!",
    "msgtype" : "m.notice",
    "format" : "org.matrix.custom.html",
    "m.relates_to" : {
      "event_id" : "$nwhovtLviu_GBx5A6spm9ceDCNAZRxP5z03zBYpSDjQ",
      "m.in_reply_to" : {
        "event_id" : "$nwhovtLviu_GBx5A6spm9ceDCNAZRxP5z03zBYpSDjQ"
      },
      "rel_type" : "net.maunium.reply"
    },
    "formatted_body" : "<mx-reply><blockquote><a href='https:\/\/matrix.to\/#\/!EgoVrPyOnPSVXERlxj:gruenhage.xyz\/$nwhovtLviu_GBx5A6spm9ceDCNAZRxP5z03zBYpSDjQ'>In reply to<\/a> <a href='https:\/\/matrix.to\/#\/@tulir:maunium.net'>@tulir:maunium.net<\/a><br\/>!rss subscriptions<\/blockquote><\/mx-reply><p><strong>Subscriptions in this room:<\/strong><\/p>\n<ul>\n<li>224 - <a href=\"https:\/\/element.io\/blog\/rss\/\">Element Blog<\/a> (subscribed by <a href=\"https:\/\/matrix.to\/#\/@tulir:maunium.net\">@tulir:maunium.net<\/a>)<br \/>\n⚠️ The last 23 attempts to fetch the feed have failed!<\/li>\n<\/ul>\n"
  },
  "origin_server_ts" : 1626878135686,
  "room_id" : "!EgoVrPyOnPSVXERlxj:gruenhage.xyz",
  "event_id" : "$oONVX1DHk-UslcE6BwJIfoOb_iP5jHOG8BFFPqnKlRU",
  "unsigned" : {
    "age" : 59419
  },
  "type" : "m.room.message"
}

Version: 1.4.5

[ShadowJonathan]

I just found out where this happens;

https://github.com/matrix-org/matrix-ios-kit/blob/e9c616ec368fbe2c2607fea7ab427c7967d016d6/MatrixKit/Utils/EventFormatter/MXKEventFormatter.m#L1840

Long story short, it's taking advantage of reply fallbacks, and is using a regex to find the first a tag.

---

As an extra note; there have been a few things said about using regex to match html...

[ShadowJonathan]

The specific case above is because the initial two links in the fallback use ' quotation marks instead of ".

However, instead of simply fixing this, I'm asking if someone can look at the whole bit of needed code, and find a way to rip it out instead.