Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable translations for languages that are ready #5048

Closed
2 tasks
DUCKCHI opened this issue Oct 25, 2021 · 3 comments · Fixed by #5449
Closed
2 tasks

Enable translations for languages that are ready #5048

DUCKCHI opened this issue Oct 25, 2021 · 3 comments · Fixed by #5449
Labels
L10n T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements

Comments

@DUCKCHI
Copy link
Contributor

DUCKCHI commented Oct 25, 2021

Languages to be added

  • Indonesian
  • Slovak (sk)

Original issue

Steps to reproduce

    1. Where are you starting? What can you see?
      some language, such as korean are not displayed in the Language tab of the settings.
      Some languages with translated on translate.element.io(element-ios) are not displayed on the app.
    1. What do you click?
      Settings -> Language

What happened?

Translation is not available because a some language is not displayed in Language taps. (Like koreans..)

What did you expect?

What happened?

Your phone model

IPHONE 12

Operating system version

iOS 15

Application version

v1.6.5

Homeserver

matrix.org

Have you submitted a rageshake?

No

Update

We only add languages when the coverage is above 80%. The work for this issue is to check our coverage and add any languages that hit this criteria and are not currently displayed (EG: Indonesian).
This issue will be closed when we have added all languages with more than 80% coverage but may be reopened, or a new one created, when other languages hit this threshold. - DK (PM)

@DUCKCHI DUCKCHI added the T-Defect Something isn't working: bugs, crashes, hangs and other reported problems label Oct 25, 2021
@DUCKCHI DUCKCHI changed the title No specific language is displayed. Some Language is not displayed in Settings -> Language taps Oct 25, 2021
@pixlwave
Copy link
Member

pixlwave commented Nov 1, 2021

Thanks for raising this @DUCKCHI, unfortunately with regards to Korean we currently aim for an 80% translation amount before adding a language to that list (Korean is showing as 60% at the moment).

@pixlwave
Copy link
Member

pixlwave commented Nov 1, 2021

I've had a look through the list and we need to add

  • Indonesian (100%)

And in contrast the following are included, some of which are significantly lower than 80%

  • Vietnamese (25%)
  • Icelandic (31%)
  • Catalan (36%)
  • Spanish (42%)
  • Chinese (Traditional) (43%)
  • Welsh (64%)
  • Japanese (64%)
  • Basque (68%)

@pixlwave pixlwave added T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements X-Needs-Product Requires input from the product team L10n and removed T-Defect Something isn't working: bugs, crashes, hangs and other reported problems labels Nov 1, 2021
@daniellekirkwood
Copy link
Contributor

Thanks for the info @pixlwave and for raising this to our attention @DUCKCHI

We'll stick to the principle that @pixlwave mentioned and only add translation options for languages with more than 80% coverage. Once those above 80% have been added this issue will be closed, but feel free to reopen when we hit the right threshold for Korean (or others).

I'll remove the X-Needs-Product label and update the issue body to reflect these notes.

@daniellekirkwood daniellekirkwood removed the X-Needs-Product Requires input from the product team label Nov 23, 2021
@pixlwave pixlwave changed the title Some Language is not displayed in Settings -> Language taps Enable translations for languages that are ready Jan 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
L10n T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants