Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Search results to look less like a link #5252

Closed
daniellekirkwood opened this issue Dec 6, 2021 · 6 comments · Fixed by #5497
Closed

Update Search results to look less like a link #5252

daniellekirkwood opened this issue Dec 6, 2021 · 6 comments · Fixed by #5497
Assignees
Labels
T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements Z-Ready This issue is ready for development Z-WTF WTF issues: High impact, Low Effort

Comments

@daniellekirkwood
Copy link
Contributor

daniellekirkwood commented Dec 6, 2021

Problem

When a user searches for a term its not clear that they've found what they're looking for as the "highlight" looks like a hyperlink

Solution

Instead of the green highlight, change the results to show bold and black text when there's a matching search term. Similar to Android results.

From To
Screenshot 2021-12-13 12 32 22 Screenshot 2022-02-03 at 12 58 56 pmScreenshot 2022-02-03 at 1 03 39 pm
@daniellekirkwood daniellekirkwood added T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements Z-WTF WTF issues: High impact, Low Effort labels Dec 6, 2021
@daniellekirkwood daniellekirkwood self-assigned this Dec 13, 2021
@daniellekirkwood daniellekirkwood added the Z-Ready This issue is ready for development label Jan 26, 2022
@aringenbach
Copy link
Contributor

aringenbach commented Feb 2, 2022

Hello @daniellekirkwood
How should we handle when a word is both a search result and a mention/link, like in the following example.
Should the black color from search result always override other colors ?

@daniellekirkwood
Copy link
Contributor Author

Great question @aringenbach

@amshakal can you advise here?

@daniellekirkwood daniellekirkwood added the X-Needs-Design May require input from the design team label Feb 2, 2022
@amshakal
Copy link

amshakal commented Feb 3, 2022

Great callout. I think we need an additional element to highlight searched item. On doing some competitive analysis, seems like having a yellow highlight might be the most familiar and efficient solution. Here is an example:
Screenshot 2022-02-03 at 12 58 56 pm
Screenshot 2022-02-03 at 1 03 39 pm

The highlight colour used is: FCC639 with 20% opacity for light mode and FCC639 with 30% opacity for dark mode.

Let me know if you have any questions! TY :)

@daniellekirkwood
Copy link
Contributor Author

@amshakal Should the result be in bold or highlighted, or both?

@amshakal
Copy link

amshakal commented Feb 3, 2022

I think we can do without bold.

@daniellekirkwood
Copy link
Contributor Author

Great! I've added the screenshots you provided to the issue info above and will edit the labels as needed :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements Z-Ready This issue is ready for development Z-WTF WTF issues: High impact, Low Effort
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants