Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grey spinner displays ion the wrapping banner view as well as the underlying home view, sometimes indefinitely #5407

Closed
langleyd opened this issue Jan 19, 2022 · 0 comments · Fixed by #5408
Assignees
Labels
O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Something isn't working: bugs, crashes, hangs and other reported problems

Comments

@langleyd
Copy link
Member

A grey spinner displays on the HomeViewControllerWithBannerWrapperViewController that wraps HomeViewController. Sometimes this displays indefinitely as the class does not inherit from MKXViewController and therefore doesn't receive session state updates.

Rather than inherit MXKActivityHandlingViewController which add's a spinner, we should change the wrapper to just conform to MXKViewControllerActivityHandling and just pas the hide/show methods on to the underlying HomeViewController.

@langleyd langleyd added the T-Defect Something isn't working: bugs, crashes, hangs and other reported problems label Jan 19, 2022
@langleyd langleyd self-assigned this Jan 19, 2022
@SBiOSoftWhare SBiOSoftWhare added O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist labels Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Something isn't working: bugs, crashes, hangs and other reported problems
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants