Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Loc share map picker should hide as soon as you hit ‘share’ #5571

Closed
ara4n opened this issue Feb 12, 2022 · 0 comments · Fixed by #6858
Closed

Loc share map picker should hide as soon as you hit ‘share’ #5571

ara4n opened this issue Feb 12, 2022 · 0 comments · Fixed by #6858
Labels
A-Location-Sharing O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Something isn't working: bugs, crashes, hangs and other reported problems Z-Labs

Comments

@ara4n
Copy link
Member

ara4n commented Feb 12, 2022

Steps to reproduce

  1. Send a loc share on patchy connectivity
  2. Hit the share button
  3. The share button disappears and a grey spinner appears. The map is still present
  4. You get bored, hit cancel, discover that the unsent loc is already sitting in the timeline

Outcome

What did you expect?

As soon as i hit share, hide the map picker rather than leaving you stuck in it wondering if the share worked.

What happened instead?

Stuck staring at a spinner on the map with no share button, rather than being back in the timeline

Your phone model

No response

Operating system version

No response

Application version

1.8.0 rc1

Homeserver

No response

Will you send logs?

No
@ara4n ara4n added the T-Defect Something isn't working: bugs, crashes, hangs and other reported problems label Feb 12, 2022
@pixlwave pixlwave added A-Location-Sharing O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist labels Feb 17, 2022
This was referenced Oct 11, 2022
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Location-Sharing O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Something isn't working: bugs, crashes, hangs and other reported problems Z-Labs
Projects
None yet
Milestone
No milestone
3 participants
@stefanceriu @ara4n @pixlwave