-
Notifications
You must be signed in to change notification settings - Fork 499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "Invite people"to the space menu in the left panel and update menu order #5810
Comments
@niquewoodhouse @kittykat quick questions:
|
No, it should be "Members" (Android has a PR in review to fix that)
-> Nique for decision I think it's better to make it shorter, but it's also important to fit in with other parts of the app.
Yes and to be clear, the "Invite people" option should be available even on spaces where the user isn't an admin but can still share the link or invite other users in some way. |
FYI, on Android we hide it atm if the user doesn't have permissions to invite |
to confirmed by @niquewoodhouse but I understood that is the chosen strategy all over the app. |
That was for while you couldn't do anything additive to a space in the app for iOS. So adding a room, inviting people. We thought all feedback would be "how do I add someone/a room". Now it seems like you'll be able to invite people to spaces you have the rights to? So now iOS needs to reflect Android and remove that option if user doesn't have permission.
If we do this what happens if user has dynamic type? I'd rather we leave them whatever size they are now and making such sheets better is an IA issue, so they're consistent. I think it would be strange to experience a smaller menu here but bigger elsewhere. |
Just to add, I think this could be a follow up issue if we need to get this out in this RC - what do you think @kittykat |
This is not consistent with other screens in my opinion: |
We'll need to rework Home, timeline, space members and explore room screens in this case if we want to be consistent. |
In that case, I think we should move this kind of work into IA and not spaces (how do we treat things across app when user has not enough rights/permissions) and leave it as is wdyt @kittykat ? |
Agreed, we can review the interactions as part of IA rather than Spaces. |
…nu order #5810 - update after review
…nu order #5810 - update after review
…nu order #5810 - update after review
When you open
left panel -> ⋯
menu for a Space, the first item in the list should be "Invite people", like on Android.The menu order should be:
Current screenshots:
The text was updated successfully, but these errors were encountered: