Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Authentication screen doesn't follow readable width on iPad #5898

Closed
Johennes opened this issue Mar 23, 2022 · 1 comment · Fixed by #5907
Closed

Authentication screen doesn't follow readable width on iPad #5898

Johennes opened this issue Mar 23, 2022 · 1 comment · Fixed by #5907
Labels
A-Login T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements X-Needs-Design May require input from the design team

Comments

@Johennes
Copy link
Contributor

Your use case

What would you like to do?

Restrict the width of the sign-in / register UI to the readable portion of the screen instead of stretching it to full width.

Why would you like to do it?

This is not an issue on phones but on the iPad stretching to the full screen width looks awkward (especially in landscape mode) and is not very accessible (you enter the password on one side of the screen and then have to jump over to the other side to click the login button).

How would you like to achieve it?

Constrain the view elements to the readable content guide.

Have you considered any alternatives?

No response

Additional context

Simulator Screen Shot - iPad Pro (9 7-inch) - 2022-03-23 at 10 16 04
Simulator Screen Shot - iPad Pro (9 7-inch) - 2022-03-23 at 10 16 08
@Johennes Johennes added the T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements label Mar 23, 2022
@Anderas
Copy link
Contributor

Anderas commented Mar 23, 2022 •
edited
Loading

Thanks @Johennes this is valid feedback. Worth adding that in an unrelated bugfix the Login/Register button was moved to the left side

@Anderas Anderas added A-Login X-Needs-Design May require input from the design team labels Mar 23, 2022
Johennes added a commit that referenced this issue Mar 23, 2022
@Johennes
Restrict UI components on authentication screen to readable width
c7097d4 
- Make layout margins on content view follow readable width
- Set zero edge insets on content view
- Constrain all subviews of content view to leading & trailing
  layout margins of superview

Fixes: #5898
Johennes added a commit that referenced this issue Mar 23, 2022
@Johennes
Restrict UI components on authentication screen to readable width
dabd237 
- Make layout margins on content view follow readable width
- Set zero edge insets on content view
- Constrain all subviews of content view to leading & trailing
  layout margins of superview

Fixes: #5898
Signed-off-by: Johannes Marbach <[email protected]>
@Johennes Johennes mentioned this issue Mar 23, 2022
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Login T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements X-Needs-Design May require input from the design team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Restrict UI components on authentication screen to readable width element-hq/element-ios
2 participants
@Johennes @Anderas