Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change text when swiping on room from Delete to Leave #6568

Merged
merged 2 commits into from
Aug 18, 2022

Conversation

aaronraimist
Copy link
Contributor

@aaronraimist aaronraimist commented Aug 14, 2022

Before After

Signed-off-by: Aaron Raimist [email protected]

Pull Request Checklist

  • I read the contributing guide
  • UI change has been tested on both light and dark themes, in portrait and landscape orientations and on iPhone and iPad simulators
  • Accessibility has been taken into account.
  • Pull request is based on the develop branch
  • Pull request contains a changelog file in ./changelog.d
  • You've made a self review of your PR
  • Pull request includes screenshots or videos of UI changes
  • Pull request includes a sign off

@codecov-commenter
Copy link

Codecov Report

Merging #6568 (8a913d0) into develop (6f0d796) will increase coverage by 0.04%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           develop    #6568      +/-   ##
===========================================
+ Coverage     6.28%    6.32%   +0.04%     
===========================================
  Files         1458     1458              
  Lines       153924   153927       +3     
  Branches     61867    61868       +1     
===========================================
+ Hits          9668     9731      +63     
+ Misses      143850   143790      -60     
  Partials       406      406              
Impacted Files Coverage Δ
...iot/Modules/Common/Recents/RecentsViewController.m 8.71% <0.00%> (-0.02%) ⬇️
...rs/EncryptionKeyManager/EncryptionKeyManager.swift 35.41% <0.00%> (-4.17%) ⬇️
...xKit/Controllers/MXKAuthenticationViewController.m 19.01% <0.00%> (ø)
...ing/SplashScreen/View/OnboardingSplashScreen.swift 58.66% <0.00%> (+4.00%) ⬆️
Riot/Categories/String.swift 33.33% <0.00%> (+11.11%) ⬆️
...Modules/Common/ViewModel/StateStoreViewModel.swift 50.00% <0.00%> (+19.44%) ⬆️
...SplashScreen/OnboardingSplashScreenViewModel.swift 53.84% <0.00%> (+42.30%) ⬆️
...dules/Room/EmojiPicker/Data/Store/EmojiStore.swift 93.02% <0.00%> (+93.02%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@pixlwave pixlwave requested a review from gileluard August 17, 2022 11:42
@pixlwave
Copy link
Member

pixlwave commented Aug 17, 2022

@gileluard I think you have the most recent context on this area, so I've assigned to you :)

Copy link
Contributor

@gileluard gileluard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@pixlwave
Copy link
Member

Thanks for your contribution @aaronraimist, I can't see a sign-off on this PR, otherwise we're happy to merge this 👍

@aaronraimist
Copy link
Contributor Author

Oops. Here you go.

Signed-off-by: Aaron Raimist [email protected]

@gileluard gileluard merged commit 7d144f0 into element-hq:develop Aug 18, 2022
@aaronraimist aaronraimist deleted the delete-leave branch August 18, 2022 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants