Device manager: User sessions overview - Other sessions section read only (PSG-667) #6672

SBiOSoftWhare · 2022-09-05T09:17:42Z

Light	Dark

github-actions · 2022-09-05T14:04:41Z

📱 Scan the QR code below to install the build for this PR.
🔒 This build is for internal testing purpose. Only devices listed in the ad-hoc provisioning profile can install Element Alpha.

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/aQxbpG

pixlwave

Woah, the Device Manager looks like it's going to be a cool new feature 😎

Comments inline :)

Riot/Assets/en.lproj/Vector.strings

RiotSwiftUI/Modules/UserSessions/UserSessionInfo/UserSessionInfo.swift

...odules/UserSessions/UserSessionsOverview/Service/MatrixSDK/UserSessionsOverviewService.swift

RiotSwiftUI/Modules/UserSessions/UserSessionsOverview/UserSessionsOverviewViewModel.swift

pixlwave · 2022-09-06T16:35:13Z

RiotSwiftUI/Modules/UserSessions/UserSessionsOverview/View/UserSessionListItem.swift

+
+    @Environment(\.theme) private var theme: ThemeSwiftUI
+
+    private var sessionTitle: String {


Could this, sessionDetailsText and lastActivityDateString(from:) be moved into UserSessionListItemViewData instead? It would make the view implementation clearing keeping all this logic out of it.

RiotSwiftUI/Modules/UserSessions/UserSessionsOverview/View/UserSessionListItem.swift

RiotSwiftUI/Modules/UserSessions/UserSessionsOverview/View/UserSessionsOverview.swift

pixlwave · 2022-09-06T17:04:10Z

RiotSwiftUI/Modules/UserSessions/UserSessionsOverview/View/UserSessionsOverview.swift

+                    .padding(.horizontal, 16)
+
+                    // Device list
+                    VStack(spacing: 16) {


Could use a LazyVStack here given we're emulating a List.

Side note: Might be worth looking at VectorForm and using/extending that for use in this view :)

VectorForm has the separators already implemented too 😉

RiotSwiftUI/Modules/UserSessions/DeviceAvatar/DeviceAvatarView.swift

…MatrixSDK/UserSessionsOverviewService.swift Co-authored-by: Doug <[email protected]>

….swift Co-authored-by: Doug <[email protected]>

…rSessionListItem.swift Co-authored-by: Doug <[email protected]>

…ionsOverviewViewModel.swift Co-authored-by: Doug <[email protected]>

…tring.

…building.

codecov-commenter · 2022-09-07T11:55:49Z

Codecov Report

Merging #6672 (111c829) into develop (cc2115e) will increase coverage by 3.74%.
The diff coverage is 30.21%.

@@             Coverage Diff             @@
##           develop    #6672      +/-   ##
===========================================
+ Coverage     6.23%    9.98%   +3.74%     
===========================================
  Files         1474     1486      +12     
  Lines       155154   157045    +1891     
  Branches     62259    62950     +691     
===========================================
+ Hits          9679    15685    +6006     
+ Misses      145072   140807    -4265     
- Partials       403      553     +150

Impacted Files	Coverage Δ
Riot/Generated/Images.swift	`58.18% <ø> (+3.41%)`	⬆️
...s/UserSessions/DeviceAvatar/DeviceAvatarView.swift	`0.00% <0.00%> (ø)`
.../Coordinator/UserSessionsOverviewCoordinator.swift	`0.00% <0.00%> (ø)`
...ervice/MatrixSDK/UserSessionsOverviewService.swift	`0.00% <0.00%> (ø)`
...serSessionsOverview/View/UserSessionListItem.swift	`0.00% <0.00%> (ø)`
...erSessionsOverview/View/UserSessionsOverview.swift	`0.00% <0.00%> (ø)`
...ssionsOverview/UserSessionsOverviewViewModel.swift	`46.47% <48.21%> (+46.47%)`	⬆️
...s/UserSessions/DeviceType/DeviceType+Element.swift	`48.57% <48.57%> (ø)`
Riot/Generated/Strings.swift	`10.15% <58.33%> (+7.29%)`	⬆️
...Service/Mock/MockUserSessionsOverviewService.swift	`83.33% <83.33%> (ø)`
... and 315 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Johennes · 2022-09-07T13:37:30Z

RiotSwiftUI/Modules/UserSessions/DeviceType/DeviceType+Element.swift

+    var name: String {
+        let name: String
+
+        let appName = AppInfo.current.displayName


Will this not show the current app's bundle display name for all devices?

Yes atm the application short name Element is taken from the bundle display name in the app. This is probably something we set in other place like BuildSettings or specific translation file in the future.
The parsing of client name is not yet implemented. So there is chances to change the client name generation in the future also.

...odules/UserSessions/UserSessionsOverview/Service/MatrixSDK/UserSessionsOverviewService.swift

pixlwave

Not sure who this is going to now, but LGTM

RiotSwiftUI/Modules/UserSessions/DeviceAvatar/DeviceAvatarView.swift

….swift

sonarqubecloud · 2022-09-12T10:40:54Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

Johennes · 2022-09-13T07:56:35Z

Not sure who this is going to now, but LGTM

Thanks @pixlwave. @paleksandrs is picking this up from Stève.

SBiOSoftWhare added 11 commits September 5, 2022 10:34

Device manager: Add strings.

2598fad

Device manager: Add assets.

3e5650d

Create DeviceType enum.

f6d7fb1

Create DeviceAvatarView.

89fe99f

Create UserSessionInfo that represents a user session information.

cbce4e5

Create UserSessionListItem view.

3adf2a8

Implement UserSessionsOverviewService.

fe89156

UserSessionsOverviewService: Fix UserSessionInfo last seen ts building.

2f2bc83

Create UserSessionsOverview screen.

3e30a19

User sessions overview: Add strings.

3d72602

UserSessionsOverview: Add text headers to other sessions section.

f9bd8c1

UserSessionsOverview: Fix safe area background color.

89faeea

SBiOSoftWhare marked this pull request as ready for review September 6, 2022 14:48

SBiOSoftWhare requested review from a team and pixlwave and removed request for a team September 6, 2022 14:49

Add changes

a7bdaad

pixlwave reviewed Sep 6, 2022

View reviewed changes

SBiOSoftWhare and others added 10 commits September 7, 2022 10:50

Update RiotSwiftUI/Modules/UserSessions/UserSessionsOverview/Service/…

cfaf554

…MatrixSDK/UserSessionsOverviewService.swift Co-authored-by: Doug <[email protected]>

Update RiotSwiftUI/Modules/UserSessions/DeviceAvatar/DeviceAvatarView…

af05a62

….swift Co-authored-by: Doug <[email protected]>

Update RiotSwiftUI/Modules/UserSessions/UserSessionsOverview/View/Use…

702e9b4

…rSessionListItem.swift Co-authored-by: Doug <[email protected]>

Update RiotSwiftUI/Modules/UserSessions/UserSessionsOverview/UserSess…

a4d8eb5

…ionsOverviewViewModel.swift Co-authored-by: Doug <[email protected]>

DeviceAvatarView: SImplify layout.

8144e1f

UserSessionListItem: Improve layout.

6a9a8bf

Create UserSessionNameFormatter to build user session name.

d6e2ff5

Create UserSessionLastActivityFormatter to build last activity date s…

03aaae4

…tring.

UserSessionListItemViewData: Handles session name and details string …

1d71de7

…building.

Update MockUserSessionsOverviewService.

93a4fc8

Strings: Add comment for user session name format.

09939ec

Johennes reviewed Sep 7, 2022

View reviewed changes

UserSessionListItem: Improve layout and handle separator.

0b061dc

Johennes reviewed Sep 7, 2022

View reviewed changes

...odules/UserSessions/UserSessionsOverview/Service/MatrixSDK/UserSessionsOverviewService.swift Show resolved Hide resolved

SBiOSoftWhare added 5 commits September 7, 2022 15:47

UserSessionsOverview: Improve layout.

f733171

UserSessionsOverview: Improve other sessions list layout.

625b6d0

UserSessionListItem: Fix runtime issue.

ea91f5d

MockAppScreens: Add MockUserSessionsOverviewScreenState.

3038805

UserSessionsOverviewViewModelResult: Remove useless case.

111c829

SBiOSoftWhare mentioned this pull request Sep 8, 2022

Device manager: User sessions overview - Current session section (PSG-670) #6696

Merged

pixlwave approved these changes Sep 12, 2022

View reviewed changes

RiotSwiftUI/Modules/UserSessions/DeviceAvatar/DeviceAvatarView.swift Outdated Show resolved Hide resolved

Update RiotSwiftUI/Modules/UserSessions/DeviceAvatar/DeviceAvatarView…

940fbdd

….swift

pixlwave merged commit b02834a into develop Sep 12, 2022

pixlwave deleted the steve/6656_dm_overview_other_sessions branch September 12, 2022 10:39

paleksandrs linked an issue Sep 20, 2022 that may be closed by this pull request

Device manager: User sessions overview - Other sessions section read only #6656

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Device manager: User sessions overview - Other sessions section read only (PSG-667) #6672

Device manager: User sessions overview - Other sessions section read only (PSG-667) #6672

SBiOSoftWhare commented Sep 5, 2022 •

edited

Loading

github-actions bot commented Sep 5, 2022 •

edited

Loading

pixlwave left a comment

pixlwave Sep 6, 2022

pixlwave Sep 6, 2022

pixlwave Sep 6, 2022

codecov-commenter commented Sep 7, 2022 •

edited

Loading

Johennes Sep 7, 2022

SBiOSoftWhare Sep 7, 2022

pixlwave left a comment

sonarqubecloud bot commented Sep 12, 2022

Johennes commented Sep 13, 2022


		@Environment(\.theme) private var theme: ThemeSwiftUI

		private var sessionTitle: String {

Device manager: User sessions overview - Other sessions section read only (PSG-667) #6672

Device manager: User sessions overview - Other sessions section read only (PSG-667) #6672

Conversation

SBiOSoftWhare commented Sep 5, 2022 • edited Loading

github-actions bot commented Sep 5, 2022 • edited Loading

pixlwave left a comment

Choose a reason for hiding this comment

pixlwave Sep 6, 2022

Choose a reason for hiding this comment

pixlwave Sep 6, 2022

Choose a reason for hiding this comment

pixlwave Sep 6, 2022

Choose a reason for hiding this comment

codecov-commenter commented Sep 7, 2022 • edited Loading

Codecov Report

Johennes Sep 7, 2022

Choose a reason for hiding this comment

SBiOSoftWhare Sep 7, 2022

Choose a reason for hiding this comment

pixlwave left a comment

Choose a reason for hiding this comment

sonarqubecloud bot commented Sep 12, 2022

Johennes commented Sep 13, 2022

SBiOSoftWhare commented Sep 5, 2022 •

edited

Loading

github-actions bot commented Sep 5, 2022 •

edited

Loading

codecov-commenter commented Sep 7, 2022 •

edited

Loading