Unverified sessions alert #7056
Conversation
|
Kudos, SonarCloud Quality Gate passed!
|
paleksandrs
requested review from
a team and
phloux
and removed request for
a team
Codecov ReportBase: 11.78% // Head: 11.81% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #7056 +/- ##
===========================================
+ Coverage 11.78% 11.81% +0.03%
===========================================
Files 1611 1615 +4
Lines 158184 158427 +243
Branches 64245 64369 +124
===========================================
+ Hits 18640 18726 +86
- Misses 138914 139063 +149
- Partials 630 638 +8
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
| self.init(userDefaults: UserDefaults.standard) | ||
| } | ||
|
|
||
| init(userDefaults: UserDefaults = UserDefaults.standard) { |
There was a problem hiding this comment.
Why did you add the userDefaults parameter ? It seems to be not used at this time (otherwise than in the previous convenience init in this file)
There was a problem hiding this comment.
It is being used in unit tests to inject userdefaults
There was a problem hiding this comment.
Sorry, I hadn't the Unit Tests in mind. It's ok for me 🙂
| @objcMembers | ||
| class ReviewSessionAlertSnoozeController: NSObject { | ||
|
|
||
| private let userDefaults: UserDefaults |
There was a problem hiding this comment.
I think the 2 following init methods will be useless if you instantiate userDefaults value right here.
Closses #7043
Change current unverified sessions alert using following ACs: