Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin Xcode version to 14.2. The app is currently failing ASC validatio… #7476

Merged
merged 1 commit into from
Apr 5, 2023

Conversation

stefanceriu
Copy link
Member

…n on using private symbols from Down.

@stefanceriu stefanceriu requested a review from pixlwave April 5, 2023 06:32
@codecov
Copy link

codecov bot commented Apr 5, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (0e25cf1) 12.29% compared to head (eb84e56) 12.29%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #7476   +/-   ##
========================================
  Coverage    12.29%   12.29%           
========================================
  Files         1645     1645           
  Lines       163152   163152           
  Branches     66991    66990    -1     
========================================
  Hits         20063    20063           
  Misses      142439   142439           
  Partials       650      650           
Flag Coverage Δ
uitests 55.24% <ø> (ø)
unittests 6.18% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR probably needs a .build changelog saying it is hard-pinned to 14.2, otherwise looks good to me.

@stefanceriu stefanceriu force-pushed the stefan/xcodeVersionFix branch from eb84e56 to b11ee33 Compare April 5, 2023 09:54
@stefanceriu stefanceriu merged commit 0aef339 into develop Apr 5, 2023
@stefanceriu stefanceriu deleted the stefan/xcodeVersionFix branch April 5, 2023 09:55
@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants