Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

User suggestion list height doesn't match container on iOS 16+ #7492

Closed
aringenbach opened this issue Apr 12, 2023 · 0 comments · Fixed by #7500
Closed

User suggestion list height doesn't match container on iOS 16+ #7492

aringenbach opened this issue Apr 12, 2023 · 0 comments · Fixed by #7500
Assignees
@aringenbach
Labels
A-Composer A-Room O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Something isn't working: bugs, crashes, hangs and other reported problems

Comments

@aringenbach
Copy link
Contributor

aringenbach commented Apr 12, 2023 •
edited
Loading

Steps to reproduce

  1. Go to a room
  2. Type @... with a pattern that would match just a couple/few users

Outcome

What did you expect?

User suggestion list displays multiple users nicely, given that there is enough room for it

What happened instead?

User suggestion list height is bigger than the container's (container size is "manually" calculated). This is probably due to the fact that on iOS 16, SwiftUI's List component switches from using a UITableView to a UICollectionView. The implemented calculation matches the expected standard vertical spacing of the previous component.

Simulator Screen Shot - iPhone 14 Pro - 2023-04-12 at 16 47 46

Your phone model

Any

Operating system version

iOS 16.0+

Application version

develop

Homeserver

Any

Will you send logs?

No
@aringenbach aringenbach added the T-Defect Something isn't working: bugs, crashes, hangs and other reported problems label Apr 12, 2023
@aringenbach aringenbach self-assigned this Apr 12, 2023
@aringenbach aringenbach added A-Composer A-Room S-Minor Impairs non-critical functionality or suitable workarounds exist O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience labels Apr 12, 2023
@aringenbach aringenbach mentioned this issue Apr 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aringenbach aringenbach

Labels
A-Composer A-Room O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Something isn't working: bugs, crashes, hangs and other reported problems
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix user suggestion list item height on iOS 16+ element-hq/element-ios
1 participant
@aringenbach