Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide phone number and explanation if homeserver doesn't have 3pid capability enabled #7670

Merged
merged 2 commits into from
Sep 8, 2023
Merged

Hide phone number and explanation if homeserver doesn't have 3pid capability enabled #7670

merged 2 commits into from
Sep 8, 2023

Conversation

hughns
Copy link
Member

@hughns hughns commented Sep 8, 2023 •
edited
Loading

This should have been included in #7645 but was forgotten.

Pull Request Checklist

  • I read the contributing guide
  • UI change has been tested on both light and dark themes, in portrait and landscape orientations and on iPhone and iPad simulators
  • Accessibility has been taken into account.
  • Pull request is based on the develop branch
  • Pull request contains a changelog file in ./changelog.d
  • You've made a self review of your PR
  • Pull request includes screenshots or videos of UI changes
  • Pull request includes a sign off

@hughns hughns changed the title Hide phone number and explanation if homeserver doesn't have 3pid cap… Hide phone number and explanation if homeserver doesn't have 3pid capability enabled Sep 8, 2023
@hughns hughns force-pushed the hughns/3pid-capability branch from 710554e to d097980 Compare September 8, 2023 14:24
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (11.0.14) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@hughns hughns marked this pull request as ready for review September 8, 2023 14:28
@hughns hughns requested review from Velin92 and pixlwave September 8, 2023 14:29
pixlwave
pixlwave approved these changes Sep 8, 2023
View reviewed changes
Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the PR Hugh 😎

@pixlwave pixlwave merged commit 19e13e0 into develop Sep 8, 2023
@pixlwave pixlwave deleted the hughns/3pid-capability branch September 8, 2023 16:17
Fang-NB-Plus pushed a commit to innet8/element-ios that referenced this pull request Dec 26, 2023
@hughns @Fang-NB-Plus
Hide phone number and explanation if homeserver doesn't have 3pid cap…
c277d1a 
…ability enabled (element-hq#7670)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pixlwave pixlwave pixlwave approved these changes

@Velin92 Velin92 Awaiting requested review from Velin92

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hughns @pixlwave